| Message ID | 1393363535-15222-1-git-send-email-tommusta@gmail.com |
|---|---|
| State | New |
| Headers | show |
On 02/25/2014 01:25 PM, Tom Musta wrote: > Per Richard Henderson's review, the array of masks used in the > vgbbd instruction should be declared as static const. > > Signed-off-by: Tom Musta <tommusta@gmail.com> > --- > target-ppc/int_helper.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Reviewed-by: Richard Henderson <rth@twiddle.net> r~
diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c index 63dde94..582d8ac 100644 --- a/target-ppc/int_helper.c +++ b/target-ppc/int_helper.c @@ -1075,7 +1075,7 @@ void helper_vbpermq(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) #undef VBPERMQ_INDEX #undef VBPERMQ_DW -uint64_t VGBBD_MASKS[256] = { +static const uint64_t VGBBD_MASKS[256] = { 0x0000000000000000ull, /* 00 */ 0x0000000000000080ull, /* 01 */ 0x0000000000008000ull, /* 02 */
Per Richard Henderson's review, the array of masks used in the vgbbd instruction should be declared as static const. Signed-off-by: Tom Musta <tommusta@gmail.com> --- target-ppc/int_helper.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)