From patchwork Wed Jan 15 10:08:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bandan Das X-Patchwork-Id: 311049 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B22562C00A5 for ; Wed, 15 Jan 2014 21:10:28 +1100 (EST) Received: from localhost ([::1]:53398 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3NQX-0000NN-SF for incoming@patchwork.ozlabs.org; Wed, 15 Jan 2014 05:10:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3NPq-0000EX-MM for qemu-devel@nongnu.org; Wed, 15 Jan 2014 05:09:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3NPi-0004kf-HA for qemu-devel@nongnu.org; Wed, 15 Jan 2014 05:09:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3NPi-0004kQ-1I for qemu-devel@nongnu.org; Wed, 15 Jan 2014 05:09:34 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0FA9XAj008851 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 Jan 2014 05:09:33 -0500 Received: from aqua.pnq.redhat.com (dhcp193-3.pnq.redhat.com [10.65.193.3]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0FA9PFp017656; Wed, 15 Jan 2014 05:09:30 -0500 From: Bandan Das To: qemu-devel@nongnu.org Date: Wed, 15 Jan 2014 15:38:05 +0530 Message-Id: <1389780486-10826-2-git-send-email-bsd@redhat.com> In-Reply-To: <1389780486-10826-1-git-send-email-bsd@redhat.com> References: <1389780486-10826-1-git-send-email-bsd@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: alex.williamson@redhat.com Subject: [Qemu-devel] [PATCH v2 1/2] vfio: warn if host device rom can't be read X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org If the device rom can't be read, report an error to the user. This alerts the user that the device has a bad state that is causing rom read failure or option rom loading has been disabled from the device boot menu (among other reasons). Signed-off-by: Bandan Das --- v2: Removed the macros to print only once. We want to print the warning message for each assigned device for which rom read fails hw/misc/vfio.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 9aecaa8..d2e68e2 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/vfio.c @@ -1125,6 +1125,13 @@ static void vfio_pci_load_rom(VFIODevice *vdev) vdev->rom_offset = reg_info.offset; if (!vdev->rom_size) { + error_report("vfio-pci: Cannot read device rom at " + "%04x:%02x:%02x.%x\n", + vdev->host.domain, vdev->host.bus, vdev->host.slot, + vdev->host.function); + error_printf("Device option ROM contents are probably invalid " + "(check dmesg).\nSkip option ROM probe with rombar=0, " + "or load from file with romfile=\n"); return; }