From patchwork Tue Jan 7 21:00:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 307895 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 08C242C00AC for ; Wed, 8 Jan 2014 10:22:10 +1100 (EST) Received: from localhost ([::1]:42916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dra-0007Lk-Ep for incoming@patchwork.ozlabs.org; Tue, 07 Jan 2014 16:07:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dma-0003VP-R5 for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0dmW-0003bp-4N for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:52 -0500 Received: from mail-qe0-x232.google.com ([2607:f8b0:400d:c02::232]:39666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dmV-0003bb-Uw for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:48 -0500 Received: by mail-qe0-f50.google.com with SMTP id 1so936596qec.23 for ; Tue, 07 Jan 2014 13:01:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=5sZvTSscwU/QF7m3AwvlsyPJP16rxnMZbWErNas/egU=; b=B+tP7+OwviVcxeHVigPXFJJVfKIaII7uSNl9KV14ori9Hvx2KAVkLFBrZmp8otpHQr JVN55POwRslu3gRGzy5Bjy2Cz35TLPyodOW1M2Hl3j1AeHU40tuyPmmwoRlmoTwn5Cmb ITUYKONwKeAB1FWK1nCfGYsnvYASOStVcmMS2JU/BumNlGN5CKDWcWbCX1swv+PfHkx/ qYHWAe1trgRuz2qfBgOu+dN0R80gth9KtlyWaf0RpmW0TL1+FBZCQ5N3QcyBPhixBwav uiZ2Kzv4J7ZvKvtE0BZ0Wsq8s9IamLzsjxw/os1AcA7n+UJUZ9XVq0b8bbawRboep650 MGqg== X-Received: by 10.49.86.169 with SMTP id q9mr198562766qez.19.1389128507150; Tue, 07 Jan 2014 13:01:47 -0800 (PST) Received: from anchor.com (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id d7sm22444571qam.5.2014.01.07.13.01.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2014 13:01:46 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 7 Jan 2014 13:00:08 -0800 Message-Id: <1389128439-10067-19-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: <1389128439-10067-1-git-send-email-rth@twiddle.net> References: <1389128439-10067-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c02::232 Cc: aliguori@amazon.com Subject: [Qemu-devel] [PULL 18/49] target-i386: Use MO_BE for movbe X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Fold the bswap into the memory operation. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-i386/translate.c | 40 +++++----------------------------------- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index cfd75dc..c07062c 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -3869,44 +3869,14 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b, ot = MO_64; } - /* Load the data incoming to the bswap. Note that the TCG - implementation of bswap requires the input be zero - extended. In the case of the loads, we simply know that - gen_op_ld_v via gen_ldst_modrm does that already. */ - if ((b & 1) == 0) { - gen_ldst_modrm(env, s, modrm, ot, OR_TMP0, 0); - } else { - switch (ot) { - case MO_16: - tcg_gen_ext16u_tl(cpu_T[0], cpu_regs[reg]); - break; - default: - tcg_gen_ext32u_tl(cpu_T[0], cpu_regs[reg]); - break; - case MO_64: - tcg_gen_mov_tl(cpu_T[0], cpu_regs[reg]); - break; - } - } - - switch (ot) { - case MO_16: - tcg_gen_bswap16_tl(cpu_T[0], cpu_T[0]); - break; - default: - tcg_gen_bswap32_tl(cpu_T[0], cpu_T[0]); - break; -#ifdef TARGET_X86_64 - case MO_64: - tcg_gen_bswap64_tl(cpu_T[0], cpu_T[0]); - break; -#endif - } - + gen_lea_modrm(env, s, modrm); if ((b & 1) == 0) { + tcg_gen_qemu_ld_tl(cpu_T[0], cpu_A0, + s->mem_index, ot | MO_BE); gen_op_mov_reg_T0(ot, reg); } else { - gen_ldst_modrm(env, s, modrm, ot, OR_TMP0, 1); + tcg_gen_qemu_st_tl(cpu_regs[reg], cpu_A0, + s->mem_index, ot | MO_BE); } break;