From patchwork Tue Jan 7 21:00:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 307885 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D0CA92C009E for ; Wed, 8 Jan 2014 10:11:50 +1100 (EST) Received: from localhost ([::1]:42937 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dtP-0000ec-Rm for incoming@patchwork.ozlabs.org; Tue, 07 Jan 2014 16:08:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dmT-0003ES-C0 for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0dmO-0003aU-MW for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:45 -0500 Received: from mail-qe0-x230.google.com ([2607:f8b0:400d:c02::230]:62866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dmO-0003aK-Gx for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:40 -0500 Received: by mail-qe0-f48.google.com with SMTP id gc15so958159qeb.7 for ; Tue, 07 Jan 2014 13:01:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=eYvu0QBanQ3XzwDZKolzWyNDjtExV/CiXyGX703Kouw=; b=APQLLdMikRHPckmuO9Ju9evdpEHdBBObgp7JVt0N2NzVQoM+g+7vVRPppnFNxYKhDV nINSb9Y6874zZ7yTFRsZ1hA+3s5Zy1OvhysFLp1usIdtYO6eE5pqj/K4X7wwJPWzanIl VHlmGvZQYpsTP4UkkXr3GAtrNsKYiewb2YAUjaeiypx2jJlJj2xf7mkgg0+N/HQkpkRS psHe+x77kZkEBv6e3eWaLJohExz9FHnbiBsGMu1t70p1RtmB0YyFANz5stKdvDaULckW Evw3cIyPFJLB7VzoIwq/md5QGqAqN5KuFsq6KW38jOe0Pe1VyZ3f/QRA2NcokJdcJ75e cHTw== X-Received: by 10.49.12.102 with SMTP id x6mr202624255qeb.5.1389128499706; Tue, 07 Jan 2014 13:01:39 -0800 (PST) Received: from anchor.com (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id d7sm22444571qam.5.2014.01.07.13.01.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2014 13:01:39 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 7 Jan 2014 13:00:04 -0800 Message-Id: <1389128439-10067-15-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: <1389128439-10067-1-git-send-email-rth@twiddle.net> References: <1389128439-10067-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c02::230 Cc: aliguori@amazon.com Subject: [Qemu-devel] [PULL 14/49] target-i386: Fix typo in gen_push_T1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org By inspection, obviously we should be storing T[1] not T[0]. This could only happen for x86_64 in 64-bit mode with 0x66 prefix to call insn -- i.e. never. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-i386/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index a1a23a6..9205b72 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -2488,7 +2488,7 @@ static void gen_push_T1(DisasContext *s) gen_op_st_v(s, MO_64, cpu_T[1], cpu_A0); } else { gen_op_addq_A0_im(-2); - gen_op_st_v(s, MO_16, cpu_T[0], cpu_A0); + gen_op_st_v(s, MO_16, cpu_T[1], cpu_A0); } gen_op_mov_reg_A0(2, R_ESP); } else