Message ID | 1386015177-6621-4-git-send-email-will.newton@linaro.org |
---|---|
State | New |
Headers | show |
On 2 December 2013 20:12, Will Newton <will.newton@linaro.org> wrote: > The nan_exp argument is not used, so remove it. Nice catch -- this has actually been present since I originally introduced the macros (probably as cut-n-paste legacy from the compare macros). PS: you missed your signed-off-by line. Reviewed-by: Peter Maydell <peter.maydell@linaro.org> -- PMM
diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 7ba51b6..97bf627 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -6706,7 +6706,7 @@ int float128_compare_quiet( float128 a, float128 b STATUS_PARAM ) * 'compare and pick one input' because that would mishandle * NaNs and +0 vs -0. */ -#define MINMAX(s, nan_exp) \ +#define MINMAX(s) \ INLINE float ## s float ## s ## _minmax(float ## s a, float ## s b, \ int ismin STATUS_PARAM ) \ { \ @@ -6747,8 +6747,8 @@ float ## s float ## s ## _max(float ## s a, float ## s b STATUS_PARAM) \ return float ## s ## _minmax(a, b, 0 STATUS_VAR); \ } -MINMAX(32, 0xff) -MINMAX(64, 0x7ff) +MINMAX(32) +MINMAX(64) /* Multiply A by 2 raised to the power N. */