diff mbox

[01/17] QAPI: introduce migration capability x_unix_page_flipping

Message ID 1385975957-22941-2-git-send-email-lilei@linux.vnet.ibm.com
State New
Headers show

Commit Message

Lei Li Dec. 2, 2013, 9:19 a.m. UTC
Introduce x_unix_page_flipping to MigrationCapability for
localhost migration.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
 qapi-schema.json |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

Comments

Eric Blake March 3, 2014, 11:42 p.m. UTC | #1
On 12/02/2013 02:19 AM, Lei Li wrote:
> Introduce x_unix_page_flipping to MigrationCapability for
> localhost migration.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
>  qapi-schema.json |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)

I don't see this in git; is it something you are still interested in
adding?  If so, your subject line and commit message use '_'...

> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 83fa485..ea910ef 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -685,10 +685,20 @@
>  # @auto-converge: If enabled, QEMU will automatically throttle down the guest
>  #          to speed up convergence of RAM migration. (since 1.6)
>  #
> +# @x-unix-page-flipping: If enabled, QEMU can optimize migration when the

...while the code correctly uses '-'.
diff mbox

Patch

diff --git a/qapi-schema.json b/qapi-schema.json
index 83fa485..ea910ef 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -685,10 +685,20 @@ 
 # @auto-converge: If enabled, QEMU will automatically throttle down the guest
 #          to speed up convergence of RAM migration. (since 1.6)
 #
+# @x-unix-page-flipping: If enabled, QEMU can optimize migration when the
+#          destination is a QEMU process that runs on the same host as
+#          the source (as is the case for live upgrade).  If the migration
+#          transport is a Unix socket, QEMU will flip RAM pages directly to
+#          the destination, so that memory is only allocated twice for the
+#          source and destination processes. Disabled by default.
+#          Experimental: will get rid of the x tag after further testing with
+#          the new vmsplice. (since 2.0)
+#
 # Since: 1.2
 ##
 { 'enum': 'MigrationCapability',
-  'data': ['xbzrle', 'x-rdma-pin-all', 'auto-converge', 'zero-blocks'] }
+  'data': ['xbzrle', 'x-rdma-pin-all', 'auto-converge', 'zero-blocks',
+           'x-unix-page-flipping'] }
 
 ##
 # @MigrationCapabilityStatus