From patchwork Thu Nov 28 16:26:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 294965 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 824232C0097 for ; Fri, 29 Nov 2013 03:30:01 +1100 (EST) Received: from localhost ([::1]:42860 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm4TW-00089O-Rr for incoming@patchwork.ozlabs.org; Thu, 28 Nov 2013 11:29:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm4Qz-0004BI-Hm for qemu-devel@nongnu.org; Thu, 28 Nov 2013 11:27:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vm4Qp-0002w7-Gx for qemu-devel@nongnu.org; Thu, 28 Nov 2013 11:27:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm4Qp-0002v2-8f for qemu-devel@nongnu.org; Thu, 28 Nov 2013 11:27:11 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rASGR6sA029236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Nov 2013 11:27:06 -0500 Received: from blackfin.pond.sub.org (ovpn-116-98.ams2.redhat.com [10.36.116.98]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rASGR4Fv023976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 28 Nov 2013 11:27:05 -0500 Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3600E200C8; Thu, 28 Nov 2013 17:27:04 +0100 (CET) From: armbru@redhat.com To: qemu-devel@nongnu.org Date: Thu, 28 Nov 2013 17:26:56 +0100 Message-Id: <1385656023-11519-4-git-send-email-armbru@redhat.com> In-Reply-To: <1385656023-11519-1-git-send-email-armbru@redhat.com> References: <1385656023-11519-1-git-send-email-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: borntraeger@de.ibm.com, marcel.a@redhat.com, afaerber@suse.de, aliguori@amazon.com, peter.maydell@linaro.org Subject: [Qemu-devel] [PATCH v4 03/10] cpu: Document why cannot_instantiate_with_device_add_yet X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell --- qom/cpu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qom/cpu.c b/qom/cpu.c index 09c15e6..6e0d54e 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -254,7 +254,11 @@ static void cpu_class_init(ObjectClass *klass, void *data) k->gdb_read_register = cpu_common_gdb_read_register; k->gdb_write_register = cpu_common_gdb_write_register; dc->realize = cpu_common_realizefn; - dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */ + /* + * Reason: CPUs still need special care by board code: wiring up + * IRQs, adding reset handlers, halting non-first CPUS, ... + */ + dc->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo cpu_type_info = {