From patchwork Thu Nov 28 08:39:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fam Zheng X-Patchwork-Id: 294815 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 24F882C0098 for ; Thu, 28 Nov 2013 19:45:18 +1100 (EST) Received: from localhost ([::1]:39811 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlxDn-0000nQ-L8 for incoming@patchwork.ozlabs.org; Thu, 28 Nov 2013 03:45:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vlx9Q-0001n9-HQ for qemu-devel@nongnu.org; Thu, 28 Nov 2013 03:40:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vlx9K-0001OK-BY for qemu-devel@nongnu.org; Thu, 28 Nov 2013 03:40:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vlx9J-0001OE-VJ for qemu-devel@nongnu.org; Thu, 28 Nov 2013 03:40:38 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAS8eapO019710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Nov 2013 03:40:37 -0500 Received: from ad.nay.redhat.com ([10.66.6.190]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAS8dlNK024218; Thu, 28 Nov 2013 03:40:34 -0500 From: Fam Zheng To: qemu-devel@nongnu.org Date: Thu, 28 Nov 2013 16:39:42 +0800 Message-Id: <1385627982-14675-11-git-send-email-famz@redhat.com> In-Reply-To: <1385627982-14675-1-git-send-email-famz@redhat.com> References: <1385627982-14675-1-git-send-email-famz@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com, hbrock@redhat.com, rjones@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com Subject: [Qemu-devel] [PATCH v6 10/10] block: Allow backup on referenced named BlockDriverState X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Drive backup is a read only operation on source bs. We want to allow this specific case to enable image-fleecing. Note that when image-fleecing job starts, the job still add its blocker to source bs, and any other operation on it will be blocked by that. Signed-off-by: Fam Zheng --- block.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block.c b/block.c index 25ef5c8..68bf72c 100644 --- a/block.c +++ b/block.c @@ -1036,6 +1036,8 @@ int bdrv_open_backing_file(BlockDriverState *bs, const char *backing_bs, /* Otherwise we won't be able to commit due to check in bdrv_commit */ bdrv_op_unblock(bs->backing_hd, BLOCK_OP_TYPE_COMMIT, bs->backing_blocker); + bdrv_op_unblock(bs->backing_hd, BLOCK_OP_TYPE_BACKUP_SOURCE, + bs->backing_blocker); pstrcpy(bs->backing_file, sizeof(bs->backing_file), bs->backing_hd->file->filename); pstrcpy(bs->backing_format, sizeof(bs->backing_format),