| Message ID | 1381842635-21699-1-git-send-email-lersek@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 10/15/2013 07:10 AM, Laszlo Ersek wrote: > Also sort the test-* entries in the latter. > > Signed-off-by: Laszlo Ersek <lersek@redhat.com> > --- > .gitignore | 9 --------- > tests/.gitignore | 11 +++++++++-- > 2 files changed, 9 insertions(+), 11 deletions(-) This feels backwards to me. I'd much rather have a single top-level .gitignore for everything. We are no longer in the CVS days of having a per-directory ignore file. But I'm not the maintainer, so someone with actual check-in privileges can feel free to override me preference.
On 10/15/13 16:11, Eric Blake wrote: > On 10/15/2013 07:10 AM, Laszlo Ersek wrote: >> Also sort the test-* entries in the latter. >> >> Signed-off-by: Laszlo Ersek <lersek@redhat.com> >> --- >> .gitignore | 9 --------- >> tests/.gitignore | 11 +++++++++-- >> 2 files changed, 9 insertions(+), 11 deletions(-) > > This feels backwards to me. I'd much rather have a single top-level > .gitignore for everything. We are no longer in the CVS days of having a > per-directory ignore file. Yes, I'm aware. I re-read your previous comment before posting: http://thread.gmane.org/gmane.comp.emulators.qemu/228886/focus=229185 and I agree with it in theory. However, current qemu practice (even recent patches, eg. 9dbb52e8) seem to point in the opposite direction. I don't feel strongly about this -- I just promised earlier to do it and I want it off my shouler. Thanks! Laszlo
diff --git a/.gitignore b/.gitignore index 8e1b73f..7f4c106 100644 --- a/.gitignore +++ b/.gitignore @@ -45,15 +45,6 @@ qemu-bridge-helper qemu-monitor.texi vscclient QMP/qmp-commands.txt -test-bitops -test-coroutine -test-int128 -test-opts-visitor -test-qmp-input-visitor -test-qmp-output-visitor -test-string-input-visitor -test-string-output-visitor -test-visitor-serialization fsdev/virtfs-proxy-helper fsdev/virtfs-proxy-helper.1 fsdev/virtfs-proxy-helper.pod diff --git a/tests/.gitignore b/tests/.gitignore index 425757c..dbed60f 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -6,20 +6,27 @@ check-qlist check-qstring test-aio test-bitops -test-throttle +test-coroutine test-cutils test-hbitmap test-int128 test-iov test-mul64 +test-opts-visitor test-qapi-types.[ch] test-qapi-visit.[ch] test-qdev-global-props -test-qmp-commands.h test-qmp-commands +test-qmp-commands.h test-qmp-input-strict +test-qmp-input-visitor test-qmp-marshal.c +test-qmp-output-visitor +test-string-input-visitor +test-string-output-visitor test-thread-pool +test-throttle +test-visitor-serialization test-x86-cpuid test-xbzrle *-test
Also sort the test-* entries in the latter. Signed-off-by: Laszlo Ersek <lersek@redhat.com> --- .gitignore | 9 --------- tests/.gitignore | 11 +++++++++-- 2 files changed, 9 insertions(+), 11 deletions(-)