From patchwork Sun Oct 6 09:32:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 280847 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A8C7F2C00E3 for ; Sun, 6 Oct 2013 20:49:54 +1100 (EST) Received: from localhost ([::1]:54374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSkyG-0006XU-Ik for incoming@patchwork.ozlabs.org; Sun, 06 Oct 2013 05:49:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSkxf-0006W6-9q for qemu-devel@nongnu.org; Sun, 06 Oct 2013 05:49:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VSkxa-0006Ps-EX for qemu-devel@nongnu.org; Sun, 06 Oct 2013 05:49:15 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:47356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSkxa-0006PT-6Q; Sun, 06 Oct 2013 05:49:10 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 3EA5A40D01; Sun, 6 Oct 2013 13:49:09 +0400 (MSK) Received: from tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by tsrv.corpit.ru (Postfix) with SMTP id C946251E; Sun, 6 Oct 2013 13:33:03 +0400 (MSK) Received: (nullmailer pid 25818 invoked by uid 1000); Sun, 06 Oct 2013 09:33:02 -0000 From: Michael Tokarev To: aliguori@us.ibm.com Date: Sun, 6 Oct 2013 13:32:54 +0400 Message-Id: <1381051979-25742-10-git-send-email-mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1381051979-25742-1-git-send-email-mjt@msgid.tls.msk.ru> References: <1381051979-25742-1-git-send-email-mjt@msgid.tls.msk.ru> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: =?UTF-8?q?J=C3=A1n=20Vesel=C3=BD?= , qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org Subject: [Qemu-devel] [PULL 09/14] pci-ohci: Add missing 'break' in ohci_service_td X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Ján Veselý Device communication errors need to be reported to driver. Add a debug message while at it. Signed-off-by: Jan Vesely Acked-by: Gerd Hoffmann Signed-off-by: Michael Tokarev --- hw/usb/hcd-ohci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 35f0878..0396e33 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -1143,7 +1143,9 @@ static int ohci_service_td(OHCIState *ohci, struct ohci_ed *ed) switch (ret) { case USB_RET_IOERROR: case USB_RET_NODEV: + DPRINTF("usb-ohci: got DEV ERROR\n"); OHCI_SET_BM(td.flags, TD_CC, OHCI_CC_DEVICENOTRESPONDING); + break; case USB_RET_NAK: DPRINTF("usb-ohci: got NAK\n"); return 1;