Message ID | 1379857006-17451-13-git-send-email-mst@redhat.com |
---|---|
State | New |
Headers | show |
Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto: > Detect presence of IASL compiler and use it > to process ASL source. If not there, use pre-compiled > files in-tree. Add script to update the in-tree files. > > Note: distros are known to silently update iasl > so detect correct iasl flags for the installed version on each run as > opposed to at configure time. This is not any different from a C compiler, which is likely updated much much more often than iasl. However, I don't feel strongly at all about this. Paolo
On Mon, Sep 23, 2013 at 02:36:41PM +0200, Paolo Bonzini wrote: > Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto: > > Detect presence of IASL compiler and use it > > to process ASL source. If not there, use pre-compiled > > files in-tree. Add script to update the in-tree files. > > > > Note: distros are known to silently update iasl > > so detect correct iasl flags for the installed version on each run as > > opposed to at configure time. > > This is not any different from a C compiler, which is likely updated > much much more often than iasl. Yes but it's not a theoretical issue: we did catch iasl changing flags semantics on the fly, once. I think compilers don't do this as a norm :) > However, I don't feel strongly at all > about this. > > Paolo
On 09/23/13 15:39, Michael S. Tsirkin wrote: > On Mon, Sep 23, 2013 at 02:36:41PM +0200, Paolo Bonzini wrote: >> Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto: >>> Detect presence of IASL compiler and use it >>> to process ASL source. If not there, use pre-compiled >>> files in-tree. Add script to update the in-tree files. >>> >>> Note: distros are known to silently update iasl >>> so detect correct iasl flags for the installed version on each run as >>> opposed to at configure time. >> >> This is not any different from a C compiler, which is likely updated >> much much more often than iasl. > > Yes but it's not a theoretical issue: > we did catch iasl changing flags semantics on the fly, once. > > I think compilers don't do this as a norm :) (Fully tangentially... gcc and clang emit warnings for a new set of code constructs every other week. When combined with -Werror, it's super annoying; valid and intentional code can stop to build unexpectedly. Good thing we have --disable-werror for this.) Laszlo
diff --git a/configure b/configure index 2b83936..15405e1 100755 --- a/configure +++ b/configure @@ -119,6 +119,7 @@ path_of() { # default parameters source_path=`dirname "$0"` cpu="" +iasl="iasl" interp_prefix="/usr/gnemul/qemu-%M" static="no" cross_prefix="" @@ -257,6 +258,8 @@ for opt do ;; --cxx=*) CXX="$optarg" ;; + --iasl=*) iasl="$optarg" + ;; --source-path=*) source_path="$optarg" ;; --cpu=*) cpu="$optarg" @@ -1055,6 +1058,7 @@ echo "Advanced options (experts only):" echo " --source-path=PATH path of source code [$source_path]" echo " --cross-prefix=PREFIX use PREFIX for compile tools [$cross_prefix]" echo " --cc=CC use C compiler CC [$cc]" +echo " --iasl=IASL use ACPI compiler IASL [$iasl]" echo " --host-cc=CC use C compiler CC [$host_cc] for code run at" echo " build time" echo " --cxx=CXX use C++ compiler CXX [$cxx]" @@ -4239,6 +4243,9 @@ else fi echo "PYTHON=$python" >> $config_host_mak echo "CC=$cc" >> $config_host_mak +if $iasl -h > /dev/null 2>&1; then + echo "IASL=$iasl" >> $config_host_mak +fi echo "CC_I386=$cc_i386" >> $config_host_mak echo "HOST_CC=$host_cc" >> $config_host_mak echo "CXX=$cxx" >> $config_host_mak @@ -4691,7 +4698,7 @@ for rom in seabios vgabios ; do echo "BCC=bcc" >> $config_mak echo "CPP=$cpp" >> $config_mak echo "OBJCOPY=objcopy" >> $config_mak - echo "IASL=iasl" >> $config_mak + echo "IASL=$iasl" >> $config_mak echo "LD=$ld" >> $config_mak done diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs index 45e6165..f950707 100644 --- a/hw/i386/Makefile.objs +++ b/hw/i386/Makefile.objs @@ -5,3 +5,25 @@ obj-y += pc_sysfw.o obj-$(CONFIG_XEN) += xen_domainbuild.o xen_machine_pv.o obj-y += kvmvapic.o + +iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 > /dev/null`" \ + ; then echo "$(2)"; else echo "$(3)"; fi ;) + +ifdef IASL +#IASL Present. Generate hex files from .dsl +hw/i386/%.hex: $(SRC_PATH)/hw/i386/%.dsl $(SRC_PATH)/scripts/acpi_extract_preprocess.py $(SRC_PATH)/scripts/acpi_extract.py + $(call quiet-command, cpp -P $< -o $*.dsl.i.orig, " CPP $(TARGET_DIR)$*.dsl.i.orig") + $(call quiet-command, $(PYTHON) $(SRC_PATH)/scripts/acpi_extract_preprocess.py $*.dsl.i.orig > $*.dsl.i, " ACPI_PREPROCESS $(TARGET_DIR)$*.dsl.i") + $(call quiet-command, $(IASL) $(call iasl-option,$(IASL),-Pn,) -vs -l -tc -p $* $*.dsl.i $(if $(V), , > /dev/null) 2>&1 ," IASL $(TARGET_DIR)$*.dsl.i") + $(call quiet-command, $(SRC_PATH)/scripts/acpi_extract.py $*.lst > $*.off, " ACPI_EXTRACT $(TARGET_DIR)$*.off") + $(call quiet-command, cat $*.off > $@, " CAT $(TARGET_DIR)$@") +else +#IASL Not present. Restore pre-generated hex files. +hw/i386/%.hex: $(SRC_PATH)/hw/i386/%.hex.generated + $(call quiet-command, cp -f $< $@, " CP $(TARGET_DIR)$@") +endif + +.PHONY: cleanhex +cleanhex: + rm -f hw/i386/*hex +clean: cleanhex diff --git a/scripts/update-acpi.sh b/scripts/update-acpi.sh new file mode 100644 index 0000000..b5f05ff --- /dev/null +++ b/scripts/update-acpi.sh @@ -0,0 +1,4 @@ +cd x86_64-softmmu +for file in hw/i386/*.hex; do + cp -f $file ../$file.generated +done