| Message ID | 1378932737-13422-7-git-send-email-lcapitulino@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 09/11/2013 02:52 PM, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> > --- > docs/qmp/qmp-events.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt > index 39b6016..1e91f45 100644 > --- a/docs/qmp/qmp-events.txt > +++ b/docs/qmp/qmp-events.txt > @@ -1,4 +1,4 @@ > - QEMU Monitor Protocol Events > + QEMU Machine Protocol Events > ============================ > > BALLOON_CHANGE > @@ -173,7 +173,7 @@ Data: > "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > > NIC_RX_FILTER_CHANGED > ------------------ > +--------------------- > > The event is emitted once until the query command is executed, > the first event will always be emitted. > Reviewed-by: Eric Blake <eblake@redhat.com> But incomplete. DEVICE_DELETED has a too-long delimiter, GUEST_PANICKED is out of order, and it's probably worth splitting SPICE_CONNECTED and SPICE_DISCONNECTED into separate sections (matching VNC_CONNECTED and VNC_DISCONNECTED).
On Wed, 11 Sep 2013 17:30:48 -0600 Eric Blake <eblake@redhat.com> wrote: > On 09/11/2013 02:52 PM, Luiz Capitulino wrote: > > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> > > --- > > docs/qmp/qmp-events.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt > > index 39b6016..1e91f45 100644 > > --- a/docs/qmp/qmp-events.txt > > +++ b/docs/qmp/qmp-events.txt > > @@ -1,4 +1,4 @@ > > - QEMU Monitor Protocol Events > > + QEMU Machine Protocol Events > > ============================ > > > > BALLOON_CHANGE > > @@ -173,7 +173,7 @@ Data: > > "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > > > > NIC_RX_FILTER_CHANGED > > ------------------ > > +--------------------- > > > > The event is emitted once until the query command is executed, > > the first event will always be emitted. > > > > Reviewed-by: Eric Blake <eblake@redhat.com> > > But incomplete. DEVICE_DELETED has a too-long delimiter, GUEST_PANICKED > is out of order, Fixed those. > and it's probably worth splitting SPICE_CONNECTED and > SPICE_DISCONNECTED into separate sections (matching VNC_CONNECTED and > VNC_DISCONNECTED). This probably better done in a different patch. Will left for another day.
On 09/13/2013 12:01 PM, Luiz Capitulino wrote: > On Wed, 11 Sep 2013 17:30:48 -0600 > Eric Blake <eblake@redhat.com> wrote: > > >> and it's probably worth splitting SPICE_CONNECTED and >> SPICE_DISCONNECTED into separate sections (matching VNC_CONNECTED and >> VNC_DISCONNECTED). > > This probably better done in a different patch. Will left for another day. In fact, such a better day is probably during the conversion from txt to QMP (now that we have a proposal for how to use a discriminated qmp union type for representing event types).
On Fri, 13 Sep 2013 12:16:04 -0600 Eric Blake <eblake@redhat.com> wrote: > On 09/13/2013 12:01 PM, Luiz Capitulino wrote: > > On Wed, 11 Sep 2013 17:30:48 -0600 > > Eric Blake <eblake@redhat.com> wrote: > > > > > >> and it's probably worth splitting SPICE_CONNECTED and > >> SPICE_DISCONNECTED into separate sections (matching VNC_CONNECTED and > >> VNC_DISCONNECTED). > > > > This probably better done in a different patch. Will left for another day. > > In fact, such a better day is probably during the conversion from txt to > QMP (now that we have a proposal for how to use a discriminated qmp > union type for representing event types). Yeah.
diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt index 39b6016..1e91f45 100644 --- a/docs/qmp/qmp-events.txt +++ b/docs/qmp/qmp-events.txt @@ -1,4 +1,4 @@ - QEMU Monitor Protocol Events + QEMU Machine Protocol Events ============================ BALLOON_CHANGE @@ -173,7 +173,7 @@ Data: "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } NIC_RX_FILTER_CHANGED ------------------ +--------------------- The event is emitted once until the query command is executed, the first event will always be emitted.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> --- docs/qmp/qmp-events.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)