From patchwork Wed Sep 11 16:47:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 274344 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8610F2C0172 for ; Thu, 12 Sep 2013 02:48:25 +1000 (EST) Received: from localhost ([::1]:37123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJnaZ-00036N-NY for incoming@patchwork.ozlabs.org; Wed, 11 Sep 2013 12:48:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJnaC-00031u-Tj for qemu-devel@nongnu.org; Wed, 11 Sep 2013 12:48:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJna4-0005XT-GY for qemu-devel@nongnu.org; Wed, 11 Sep 2013 12:48:00 -0400 Received: from mail-qe0-x230.google.com ([2607:f8b0:400d:c02::230]:38041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJna4-0005Wc-6p for qemu-devel@nongnu.org; Wed, 11 Sep 2013 12:47:52 -0400 Received: by mail-qe0-f48.google.com with SMTP id nd7so4668621qeb.7 for ; Wed, 11 Sep 2013 09:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=NrZoGBDoAYiL2j0G29YQkgdYQ/sDSGVd1rJ9RjE/174=; b=L/MtDvLB8f/+1DXDYDDgsYR5620R55raDKsSFau6hWUa6cUld9hka4XZuEEpI6oKO+ jKsTSxlVCquD/PvZNMpIUaApX+5AirHI4o/ID2AzbipDRbEoV6rRRxk2yZp1BVXKa4Uo CebZRxdF/+YLGr2raaoGPu4laEmpphVl2nApl8ODil6eEY6oS8ZBRYWoCSYfMwlEI/si 6U1iFC//hg+CE4eDzGYqHNXBh4kWBr6Gegwb52zqkAKTf7QJQ6/1mQSBIZDTfukM/Fkk 9jE1oWIfTFXugPFHaliJSkQtEuVv0DKidDkbB6kp+AkdHdXABdMkIe2dgUMm3uQp6W1I BjtA== X-Received: by 10.49.99.98 with SMTP id ep2mr4897442qeb.9.1378918071621; Wed, 11 Sep 2013 09:47:51 -0700 (PDT) Received: from yakj.usersys.redhat.com (net-37-117-144-28.cust.dsl.vodafone.it. [37.117.144.28]) by mx.google.com with ESMTPSA id f5sm9312897qev.8.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 11 Sep 2013 09:47:51 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 11 Sep 2013 18:47:52 +0200 Message-Id: <1378918072-1963-1-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c02::230 Cc: kwolf@redhat.com, stefanha@redhat.com Subject: [Qemu-devel] [PATCH] qemu-img: fix invalid JSON X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Single quotes for JSON are a QMP-ism, use real JSON in qemu-img output. Reported-by: Kevin Wolf Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 3e5e388..626365d 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1842,7 +1842,7 @@ static void dump_map_entry(OutputFormat output_format, MapEntry *e, (e->flags & BDRV_BLOCK_ZERO) ? "true" : "false", (e->flags & BDRV_BLOCK_DATA) ? "true" : "false"); if (e->flags & BDRV_BLOCK_OFFSET_VALID) { - printf(", 'offset': %"PRId64"", e->offset); + printf(", \"offset\": %"PRId64"", e->offset); } putchar('}');