From patchwork Mon Sep 2 11:01:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 271890 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 081822C0087 for ; Mon, 2 Sep 2013 21:22:04 +1000 (EST) Received: from localhost ([::1]:38765 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGSCo-00004s-2Q for incoming@patchwork.ozlabs.org; Mon, 02 Sep 2013 07:22:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGSCG-0008Po-VD for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:21:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGSCB-0003EM-62 for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:21:28 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:48792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGSCA-0003E3-UD; Mon, 02 Sep 2013 07:21:23 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 8760A40242; Mon, 2 Sep 2013 15:21:21 +0400 (MSK) Received: from tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by tsrv.corpit.ru (Postfix) with SMTP id 8FF86210; Mon, 2 Sep 2013 15:01:57 +0400 (MSK) Received: (nullmailer pid 14635 invoked by uid 1000); Mon, 02 Sep 2013 11:01:56 -0000 From: Michael Tokarev To: aliguori@us.ibm.com Date: Mon, 2 Sep 2013 15:01:26 +0400 Message-Id: <1378119695-14568-7-git-send-email-mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1378119695-14568-1-git-send-email-mjt@msgid.tls.msk.ru> References: <1378119695-14568-1-git-send-email-mjt@msgid.tls.msk.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org, Stefan Hajnoczi Subject: [Qemu-devel] [PULL 06/15] curl: qemu_bh_new() can never return NULL X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Stefan Hajnoczi Drop error code path which cannot be taken since qemu_bh_new() does not return NULL. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- block/curl.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/block/curl.c b/block/curl.c index e566855..ca2cedc 100644 --- a/block/curl.c +++ b/block/curl.c @@ -572,12 +572,6 @@ static BlockDriverAIOCB *curl_aio_readv(BlockDriverState *bs, acb->nb_sectors = nb_sectors; acb->bh = qemu_bh_new(curl_readv_bh_cb, acb); - - if (!acb->bh) { - DPRINTF("CURL: qemu_bh_new failed\n"); - return NULL; - } - qemu_bh_schedule(acb->bh); return &acb->common; }