From patchwork Mon Aug 26 21:00:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 269979 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 69F262C007A for ; Tue, 27 Aug 2013 07:01:33 +1000 (EST) Received: from localhost ([::1]:53016 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE3ul-0002rx-Dc for incoming@patchwork.ozlabs.org; Mon, 26 Aug 2013 17:01:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE3uB-0002nE-Bf for qemu-devel@nongnu.org; Mon, 26 Aug 2013 17:01:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VE3u5-00057p-GH for qemu-devel@nongnu.org; Mon, 26 Aug 2013 17:00:55 -0400 Received: from mail-qc0-x22e.google.com ([2607:f8b0:400d:c01::22e]:50506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE3u5-00057k-D2 for qemu-devel@nongnu.org; Mon, 26 Aug 2013 17:00:49 -0400 Received: by mail-qc0-f174.google.com with SMTP id e10so1406574qcy.33 for ; Mon, 26 Aug 2013 14:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=YIsasy+lubz/+OIbUHgMrwczX4VK4q9NnR5xtaxJAJY=; b=QHD3c1XR9+vjkOnz19xr2osrmem+TkVeI4cB+nQGs2NdtfODFNM0fSWzpPtnjIghLM aSAlEKUftVo+JxHOiuS6Hixkub4oYfsSWAVLWXPsBDRtmJ5ST36eHrRdVz+QDTqaVQGm KRod1yn9Z9dI4AFkNaTE/Mx9sjMSiFvvV4GMHALRdQtPTuX9N7A30C10cuoZFCwzxgPw Wv96V0FhTv4zOhNhV4e998n7yKTFwZkQqbYdY+qlcpgq18ub5qYYNZwDDJllwNwYqzMU cqd3aPQMtYZpR1YIDnPxV3s+8Ml4Pj7BpAs0ROIRDM1jCubfgWfOfxGvqdJQcyDkd4HA w4zA== X-Received: by 10.49.107.105 with SMTP id hb9mr5528461qeb.74.1377550848964; Mon, 26 Aug 2013 14:00:48 -0700 (PDT) Received: from anchor.com (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id q4sm24499705qah.2.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 26 Aug 2013 14:00:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 26 Aug 2013 14:00:06 -0700 Message-Id: <1377550812-908-2-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1377550812-908-1-git-send-email-rth@twiddle.net> References: <1377550812-908-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c01::22e Cc: anthony@codemonkey.ws, aurelien@aurel32.net Subject: [Qemu-devel] [PULL 1/7] tcg: Tidy generated code for tcg_outN X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Aliasing was forcing s->code_ptr to be re-read after the store. Keep the pointer in a local variable to help the compiler. Signed-off-by: Richard Henderson --- tcg/tcg.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index dac8224..42c95af 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -121,14 +121,16 @@ static inline void tcg_out8(TCGContext *s, uint8_t v) static inline void tcg_out16(TCGContext *s, uint16_t v) { - *(uint16_t *)s->code_ptr = v; - s->code_ptr += 2; + uint8_t *p = s->code_ptr; + *(uint16_t *)p = v; + s->code_ptr = p + 2; } static inline void tcg_out32(TCGContext *s, uint32_t v) { - *(uint32_t *)s->code_ptr = v; - s->code_ptr += 4; + uint8_t *p = s->code_ptr; + *(uint32_t *)p = v; + s->code_ptr = p + 4; } /* label relocation processing */