From patchwork Wed Jun 19 07:44:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 252511 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 333352C034A for ; Wed, 19 Jun 2013 17:45:34 +1000 (EST) Received: from localhost ([::1]:43822 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpD5A-0008HG-3w for incoming@patchwork.ozlabs.org; Wed, 19 Jun 2013 03:45:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpD4e-0008FS-Cq for qemu-devel@nongnu.org; Wed, 19 Jun 2013 03:45:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpD4c-0000KH-Lx for qemu-devel@nongnu.org; Wed, 19 Jun 2013 03:45:00 -0400 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:34894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpD4c-0000HI-F3 for qemu-devel@nongnu.org; Wed, 19 Jun 2013 03:44:58 -0400 Received: from blackfin.pond.sub.org (p5B32A610.dip0.t-ipconnect.de [91.50.166.16]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 8CEEFA5C62; Wed, 19 Jun 2013 09:44:56 +0200 (CEST) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E7420200B3; Wed, 19 Jun 2013 09:44:55 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Wed, 19 Jun 2013 09:44:54 +0200 Message-Id: <1371627895-27046-2-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1371627895-27046-1-git-send-email-armbru@redhat.com> References: <1371627895-27046-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:121:10e4::3 Cc: aliguori@us.ibm.com Subject: [Qemu-devel] [PATCH 1/2] libqtest: Plug fd and memory leaks in qtest_quit() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Reviewed-by: Anthony Liguori --- tests/libqtest.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 879ffe9..bb82069 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -171,12 +171,16 @@ void qtest_quit(QTestState *s) waitpid(pid, &status, 0); } + close(s->fd); + close(s->qmp_fd); + g_string_free(s->rx, true); unlink(s->pid_file); unlink(s->socket_path); unlink(s->qmp_socket_path); g_free(s->pid_file); g_free(s->socket_path); g_free(s->qmp_socket_path); + g_free(s); } static void socket_sendf(int fd, const char *fmt, va_list ap)