diff mbox

[qom-cpu,v2,03/29] gdbstub: Simplify find_cpu()

Message ID 1371398269-6213-4-git-send-email-afaerber@suse.de
State New
Headers show

Commit Message

Andreas Färber June 16, 2013, 3:57 p.m. UTC 
Use qemu_get_cpu() and CPUState::env_ptr.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 gdbstub.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

Comments

Richard Henderson June 17, 2013, 7:54 p.m. UTC | #1 
On 06/16/2013 08:57 AM, Andreas Färber wrote:
> Use qemu_get_cpu() and CPUState::env_ptr.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~
Andreas Färber June 19, 2013, 5:30 p.m. UTC | #2 
Am 17.06.2013 21:54, schrieb Richard Henderson:
> On 06/16/2013 08:57 AM, Andreas Färber wrote:
>> Use qemu_get_cpu() and CPUState::env_ptr.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> 
> Reviewed-by: Richard Henderson <rth@twiddle.net>

Thanks, applied to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Andreas
diff mbox

Patch

diff --git a/gdbstub.c b/gdbstub.c
index bbae06d..663549c 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2071,17 +2071,13 @@  static void gdb_set_cpu_pc(GDBState *s, target_ulong pc)
 
 static CPUArchState *find_cpu(uint32_t thread_id)
 {
-    CPUArchState *env;
     CPUState *cpu;
 
-    for (env = first_cpu; env != NULL; env = env->next_cpu) {
-        cpu = ENV_GET_CPU(env);
-        if (cpu_index(cpu) == thread_id) {
-            return env;
-        }
+    cpu = qemu_get_cpu(thread_id);
+    if (cpu == NULL) {
+        return NULL;
     }
-
-    return NULL;
+    return cpu->env_ptr;
 }
 
 static int gdb_handle_packet(GDBState *s, const char *line_buf)