From patchwork Thu May 23 03:38:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fam Zheng X-Patchwork-Id: 245811 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DBBDB2C0091 for ; Thu, 23 May 2013 13:39:34 +1000 (EST) Received: from localhost ([::1]:47959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfMNJ-0006Am-2X for incoming@patchwork.ozlabs.org; Wed, 22 May 2013 23:39:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfMMf-0005tq-Vl for qemu-devel@nongnu.org; Wed, 22 May 2013 23:39:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfMMZ-0004Dz-Gx for qemu-devel@nongnu.org; Wed, 22 May 2013 23:38:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfMMZ-0004Ds-6E for qemu-devel@nongnu.org; Wed, 22 May 2013 23:38:47 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4N3cko9025024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 May 2013 23:38:46 -0400 Received: from localhost.nay.redhat.com ([10.66.7.14]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4N3cFSN024477; Wed, 22 May 2013 23:38:42 -0400 From: Fam Zheng To: qemu-devel@nongnu.org Date: Thu, 23 May 2013 11:38:03 +0800 Message-Id: <1369280289-20928-6-git-send-email-famz@redhat.com> In-Reply-To: <1369280289-20928-1-git-send-email-famz@redhat.com> References: <1369280289-20928-1-git-send-email-famz@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com, jcody@redhat.com, Fam Zheng , stefanha@redhat.com Subject: [Qemu-devel] [PATCH v5 05/11] curl: add timer to BDRVCURLState X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org libcurl uses timer to manage ongoing sockets, it needs us to supply timer. This patch introduce QEMUTimer to BDRVCURLState and handles timeouts as libcurl expects (curl_multi_timer_cb sets given timeout value on the timer and curl_timer_cb calls curl_multi_socket_action on triggered). Signed-off-by: Fam Zheng --- block/curl.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/block/curl.c b/block/curl.c index fc464ad..4fd5bb9 100644 --- a/block/curl.c +++ b/block/curl.c @@ -89,6 +89,7 @@ typedef struct BDRVCURLState { QLIST_HEAD(, CURLSockInfo) socks; char *url; size_t readahead_size; + QEMUTimer *timer; /* Whether http server accept range in header */ bool accept_range; } BDRVCURLState; @@ -148,6 +149,38 @@ static size_t curl_header_cb(void *ptr, size_t size, size_t nmemb, void *opaque) return realsize; } +static void curl_timer_cb(void *opaque) +{ + int running; + BDRVCURLState *bs = (BDRVCURLState *)opaque; + DPRINTF("curl timeout!\n"); + curl_multi_socket_action(bs->multi, CURL_SOCKET_TIMEOUT, 0, &running); +} + +/* Call back for curl_multi interface */ +static int curl_multi_timer_cb(CURLM *multi, long timeout_ms, void *s) +{ + BDRVCURLState *bs = (BDRVCURLState *)s; + DPRINTF("curl multi timer cb, timeout: %ld (ms)\n", timeout_ms); + if (timeout_ms < 0) { + if (bs->timer) { + qemu_del_timer(bs->timer); + qemu_free_timer(bs->timer); + bs->timer = NULL; + } + } else if (timeout_ms == 0) { + curl_timer_cb(bs); + } else { + if (!bs->timer) { + bs->timer = qemu_new_timer_ms(host_clock, curl_timer_cb, s); + assert(bs->timer); + } + qemu_mod_timer(bs->timer, qemu_get_clock_ms(host_clock) + timeout_ms); + } + + return 0; +} + static size_t curl_read_cb(void *ptr, size_t size, size_t nmemb, void *opaque) { CURLState *s = ((CURLState*)opaque); @@ -509,6 +542,8 @@ static int curl_open(BlockDriverState *bs, QDict *options, int flags) } curl_multi_setopt(s->multi, CURLMOPT_SOCKETDATA, s); curl_multi_setopt(s->multi, CURLMOPT_SOCKETFUNCTION, curl_sock_cb); + curl_multi_setopt(s->multi, CURLMOPT_TIMERDATA, s); + curl_multi_setopt(s->multi, CURLMOPT_TIMERFUNCTION, curl_multi_timer_cb); curl_multi_socket_action(s->multi, CURL_SOCKET_TIMEOUT, 0, &running); qemu_opts_del(opts); @@ -634,6 +669,13 @@ static void curl_close(BlockDriverState *bs) int i; DPRINTF("CURL: Close\n"); + + if (s->timer) { + qemu_del_timer(s->timer); + qemu_free_timer(s->timer); + s->timer = NULL; + } + for (i=0; istates[i].in_use) curl_clean_state(&s->states[i]);