From patchwork Mon May 13 20:31:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Liguori X-Patchwork-Id: 243529 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 05F462C00A8 for ; Tue, 14 May 2013 06:32:36 +1000 (EST) Received: from localhost ([::1]:52514 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbzQA-0008RK-64 for incoming@patchwork.ozlabs.org; Mon, 13 May 2013 16:32:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbzPm-0008M0-UT for qemu-devel@nongnu.org; Mon, 13 May 2013 16:32:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UbzPl-00014F-De for qemu-devel@nongnu.org; Mon, 13 May 2013 16:32:10 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:53950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbzPk-00013q-RK for qemu-devel@nongnu.org; Mon, 13 May 2013 16:32:09 -0400 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 May 2013 06:26:42 +1000 Received: from d23dlp03.au.ibm.com (202.81.31.214) by e23smtp05.au.ibm.com (202.81.31.211) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 14 May 2013 06:26:39 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id C01153578019 for ; Tue, 14 May 2013 06:32:00 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4DKVr1r23068792 for ; Tue, 14 May 2013 06:31:53 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4DKW0ja032691 for ; Tue, 14 May 2013 06:32:00 +1000 Received: from titi.austin.rr.com (sig-9-65-228-90.mts.ibm.com [9.65.228.90]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r4DKVtG4032615; Tue, 14 May 2013 06:31:58 +1000 From: Anthony Liguori To: qemu-devel@nongnu.org Date: Mon, 13 May 2013 15:31:46 -0500 Message-Id: <1368477106-7579-2-git-send-email-aliguori@us.ibm.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1368477106-7579-1-git-send-email-aliguori@us.ibm.com> References: <1368477106-7579-1-git-send-email-aliguori@us.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13051320-1396-0000-0000-000002F64D5F X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 202.81.31.147 Cc: Paolo Bonzini , Anthony Liguori , Andreas Faerber , Aurelien Jarno Subject: [Qemu-devel] [PATCH for-1.5 2/2] qom: add casting statistics X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This is not meant to be applied but included as a reference. Signed-off-by: Anthony Liguori --- qom/object.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 88 insertions(+) diff --git a/qom/object.c b/qom/object.c index ec88231..2bfdcda 100644 --- a/qom/object.c +++ b/qom/object.c @@ -136,12 +136,33 @@ TypeImpl *type_register_static(const TypeInfo *info) return type_register(info); } +#ifdef CONFIG_QOM_CAST_STATS +typedef struct CastStats +{ + uint64_t total; + uint64_t miss; + uint64_t hit; + uint64_t rebalance; + uint64_t lookups; + uint64_t class; +} CastStats; + +#define CAST_STATS_DUMP_INTERVAL 1000000 + +static CastStats cast_stats; +static qemu_timeval cast_stats_ts; +#endif + static TypeImpl *type_get_by_name(const char *name) { if (name == NULL) { return NULL; } +#ifdef CONFIG_QOM_CAST_STATS + cast_stats.lookups++; +#endif + return type_table_lookup(name); } @@ -432,6 +453,43 @@ Object *object_dynamic_cast(Object *obj, const char *typename) return NULL; } +#ifdef CONFIG_QOM_CAST_STATS +static void cast_stats_dump(void) +{ + qemu_timeval ts; + uint64_t delta; + int64_t udelta; + + qemu_gettimeofday(&ts); + + delta = ts.tv_sec - cast_stats_ts.tv_sec; + udelta = ts.tv_usec - cast_stats_ts.tv_usec; + if (udelta < 0) { + delta += 1; + udelta += 1000000; + } + + delta *= 1000000; + delta += udelta; + + printf("casts/sec: %f\n", (double)(cast_stats.total * 1000000) / delta); + printf("hit/sec: %f\n", (double)(cast_stats.hit * 1000000) / delta); + printf("miss/sec: %f\n", (double)(cast_stats.miss * 1000000) / delta); + printf("rebalance/sec: %f\n", (double)(cast_stats.rebalance * 1000000) / delta); + printf("classes/sec: %f\n", (double)(cast_stats.class * 1000000) / delta); + printf("lookups/sec: %f\n", (double)(cast_stats.lookups * 1000000) / delta); + printf("\n"); + + cast_stats.total = 1; + cast_stats.lookups = 0; + cast_stats.miss = 0; + cast_stats.hit = 0; + cast_stats.rebalance = 0; + cast_stats.class = 0; + cast_stats_ts = ts; +} +#endif + Object *object_dynamic_cast_assert(Object *obj, const char *typename, const char *file, int line, const char *func) { @@ -442,8 +500,17 @@ Object *object_dynamic_cast_assert(Object *obj, const char *typename, int i; Object *inst; +#ifdef CONFIG_QOM_CAST_STATS + if (cast_stats.total == 0) { + qemu_gettimeofday(&cast_stats_ts); + } +#endif + for (i = 0; i < OBJECT_CLASS_CAST_CACHE; i++) { if (obj->class->cast_cache[i] == typename) { +#ifdef CONFIG_QOM_CAST_STATS + cast_stats.hit++; +#endif goto out; } } @@ -463,9 +530,19 @@ Object *object_dynamic_cast_assert(Object *obj, const char *typename, obj->class->cast_cache[i - 1] = obj->class->cast_cache[i]; } obj->class->cast_cache[i - 1] = typename; +#ifdef CONFIG_QOM_CAST_STATS + cast_stats.miss++; +#endif } out: +#ifdef CONFIG_QOM_CAST_STATS + cast_stats.total++; + + if (cast_stats.total == CAST_STATS_DUMP_INTERVAL) { + cast_stats_dump(); + } +#endif #endif return obj; } @@ -531,8 +608,15 @@ ObjectClass *object_class_dynamic_cast_assert(ObjectClass *class, #ifdef CONFIG_QOM_CAST_DEBUG int i; +#ifdef CONFIG_QOM_CAST_STATS + cast_stats.class++; +#endif + for (i = 0; i < OBJECT_CLASS_CAST_CACHE; i++) { if (class->cast_cache[i] == typename) { +#ifdef CONFIG_QOM_CAST_STATS + cast_stats.hit++; +#endif ret = class; goto out; } @@ -556,6 +640,10 @@ ObjectClass *object_class_dynamic_cast_assert(ObjectClass *class, class->cast_cache[i - 1] = class->cast_cache[i]; } class->cast_cache[i - 1] = typename; + +#ifdef CONFIG_QOM_CAST_STATS + cast_stats.miss++; +#endif } out: #endif