Message ID | 1358435794-8406-2-git-send-email-imammedo@redhat.com |
---|---|
State | New |
Headers | show |
Am 17.01.2013 16:16, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> > --- > target-i386/cpu.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 333745b..ce914da 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -1399,6 +1399,8 @@ static int cpu_x86_parse_featurestr(x86_def_t *x86_cpu_def, char *features) > goto error; > } > if (numvalue < 0x80000000) { > + fprintf(stderr, "xlevel value shall always be >= 0x80000000" > + ", fixup will be deprecated in future versions\n"); > numvalue += 0x80000000; > } > x86_cpu_def->xlevel = numvalue; This has been reviewed without objections so far, so I would apply it for 1.4. Either way you should document this intent for users already: http://wiki.qemu.org/ChangeLog/1.4 We had such discussions before, around removing cpudef support. When do you plan to remove this, and being deprecated, shouldn't it rather read "fixup will be removed in future versions"? ;) If it fits within 80 chars I can edit it myself. Cheers, Andreas
On Mon, 21 Jan 2013 09:39:07 +0100 Andreas Färber <afaerber@suse.de> wrote: > Am 17.01.2013 16:16, schrieb Igor Mammedov: > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> > > --- > > target-i386/cpu.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index 333745b..ce914da 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c > > @@ -1399,6 +1399,8 @@ static int cpu_x86_parse_featurestr(x86_def_t > > *x86_cpu_def, char *features) goto error; > > } > > if (numvalue < 0x800000 00) { > > + fprintf(stderr, "xlevel value shall always be >= > > 0x80000000" > > + ", fixup will be deprecated in future > > versions\n"); numvalue += 0x80000000; > > } > > x86_cpu_def->xlevel = numvalue; > > This has been reviewed without objections so far, so I would apply it > for 1.4. Either way you should document this intent for users already: > http://wiki.qemu.org/ChangeLog/1.4 Would be something like this suitable: xlevel argument for -cpu option, currently fix-ups it's value if it's less than 0x80000000. Fix-up will be removed in QEMU 1.6 release and users are expected to provide valid xlevel value or qemu will fail to start. > > We had such discussions before, around removing cpudef support. > > When do you plan to remove this, and being deprecated, shouldn't it > rather read "fixup will be removed in future versions"? ;) > If it fits within 80 chars I can edit it myself. No need for it, I'll fix it and respin series. > > Cheers, > Andreas > Thanks, Igor
diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 333745b..ce914da 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1399,6 +1399,8 @@ static int cpu_x86_parse_featurestr(x86_def_t *x86_cpu_def, char *features) goto error; } if (numvalue < 0x80000000) { + fprintf(stderr, "xlevel value shall always be >= 0x80000000" + ", fixup will be deprecated in future versions\n"); numvalue += 0x80000000; } x86_cpu_def->xlevel = numvalue;