From patchwork Fri Oct 19 13:31:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 192700 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 213272C0092 for ; Sat, 20 Oct 2012 00:45:45 +1100 (EST) Received: from localhost ([::1]:41755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPCjK-00006l-L9 for incoming@patchwork.ozlabs.org; Fri, 19 Oct 2012 09:35:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPChg-000694-IJ for qemu-devel@nongnu.org; Fri, 19 Oct 2012 09:33:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPChb-0006X9-3e for qemu-devel@nongnu.org; Fri, 19 Oct 2012 09:33:32 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:36749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPCha-0006Qo-UQ for qemu-devel@nongnu.org; Fri, 19 Oct 2012 09:33:27 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp2so437208pbb.4 for ; Fri, 19 Oct 2012 06:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; bh=uArjAz/jbsCqDj1sowCsmDWDv4v8Qm6H3KZt8ZMIvio=; b=AIlOdEuo5iJstuW7D2NvRVg6EIwyjrdjwB0zel9is+Tqyv3N/gJayZODnV8a5RFbH8 e08ZsCLBhjRLVUnIqiUFUnJAE1+EH8bMf1oLpToqUke35vT9bJVi9U7k5WAX8xGe45yB tlJMkCRWgSSuK4NaOAmUToNmm16uDY5UkO3zzMyR808pBgmKJo1NF+Q9TbLrW1CxJGCX naVqTjEXv7bpM+HbB0jhqtZezzjaUC9etliZYSi74j6sQuDxZFyMfTVR2b9CjQAWzFMB LXfqh9xtuY0wereas9gbiWd5sfxF3eH+NufBL90r1Vd4BUdZKH9ngYBYuZ5EUN1qp6AN 3meQ== Received: by 10.68.209.230 with SMTP id mp6mr5946243pbc.8.1350653606595; Fri, 19 Oct 2012 06:33:26 -0700 (PDT) Received: from yakj.usersys.redhat.com (93-34-169-1.ip50.fastwebnet.it. [93.34.169.1]) by mx.google.com with ESMTPS id kr4sm1240726pbc.76.2012.10.19.06.33.23 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Oct 2012 06:33:25 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 19 Oct 2012 15:31:52 +0200 Message-Id: <1350653528-5834-14-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.12.1 In-Reply-To: <1350653528-5834-1-git-send-email-pbonzini@redhat.com> References: <1350653528-5834-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.160.45 Subject: [Qemu-devel] [PATCH 13/29] vnc: avoid Yoda conditionals X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Paolo Bonzini --- ui/vnc.c | 4 ++-- 1 file modificato, 2 inserzioni(+), 2 rimozioni(-) diff --git a/ui/vnc.c b/ui/vnc.c index b893e07..2892fb7 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3066,7 +3066,7 @@ int vnc_display_open(DisplayState *ds, const char *display) vs->lsock = unix_connect(display+5, NULL); else vs->lsock = inet_connect(display, NULL); - if (-1 == vs->lsock) { + if (vs->lsock < 0) { g_free(vs->display); vs->display = NULL; return -1; @@ -3088,7 +3088,7 @@ int vnc_display_open(DisplayState *ds, const char *display) vs->lsock = inet_listen(display, dpy, 256, SOCK_STREAM, 5900, NULL); } - if (-1 == vs->lsock) { + if (vs->lsock < 0) { g_free(dpy); return -1; } else {