From patchwork Tue Sep 18 20:00:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 184840 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 064EC2C007E for ; Wed, 19 Sep 2012 06:09:54 +1000 (EST) Received: from localhost ([::1]:46857 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE40F-0000Hu-Mr for incoming@patchwork.ozlabs.org; Tue, 18 Sep 2012 16:02:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE3zL-00077d-OE for qemu-devel@nongnu.org; Tue, 18 Sep 2012 16:01:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TE3zK-0004Gb-B3 for qemu-devel@nongnu.org; Tue, 18 Sep 2012 16:01:43 -0400 Received: from vms173005pub.verizon.net ([206.46.173.5]:62484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE3zK-0004Fh-6T for qemu-devel@nongnu.org; Tue, 18 Sep 2012 16:01:42 -0400 Received: from wf-rch.minyard.home ([unknown] [173.57.151.210]) by vms173005.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0MAK006CYA9PDDO4@vms173005.mailsrvcs.net> for qemu-devel@nongnu.org; Tue, 18 Sep 2012 15:01:16 -0500 (CDT) Received: from i.minyard.home (i2.minyard.home [192.168.27.116]) by wf-rch.minyard.home (Postfix) with ESMTP id 8F7701F958; Tue, 18 Sep 2012 15:00:51 -0500 (CDT) Received: by i.minyard.home (Postfix, from userid 1000) id 7724F83E54; Tue, 18 Sep 2012 15:00:49 -0500 (CDT) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Tue, 18 Sep 2012 15:00:32 -0500 Message-id: <1347998443-20599-6-git-send-email-minyard@acm.org> X-Mailer: git-send-email 1.7.4.1 In-reply-to: <1347998443-20599-1-git-send-email-minyard@acm.org> References: <1347998443-20599-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Solaris 10 (1203?) X-Received-From: 206.46.173.5 Cc: Corey Minyard Subject: [Qemu-devel] [PATCH 05/16] qemu-char: remove free of chr from win_stdio_close X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Corey Minyard This will result in a double free on close, because it's freed in qemu_chr_delete() right after calling the close function. Signed-off-by: Corey Minyard --- qemu-char.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 9e3ac40..a94d9ef 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1949,7 +1949,6 @@ static void win_stdio_close(CharDriverState *chr) } g_free(chr->opaque); - g_free(chr); stdio_nb_clients--; }