From patchwork Sat Jun 23 00:33:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 166715 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1074BB6FA4 for ; Sat, 23 Jun 2012 11:40:45 +1000 (EST) Received: from localhost ([::1]:58516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SiEJo-0008I7-4G for incoming@patchwork.ozlabs.org; Fri, 22 Jun 2012 20:35:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SiEIv-0006br-R2 for qemu-devel@nongnu.org; Fri, 22 Jun 2012 20:34:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SiEIu-0007wH-8Z for qemu-devel@nongnu.org; Fri, 22 Jun 2012 20:34:21 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:50139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SiEIu-0007rl-09 for qemu-devel@nongnu.org; Fri, 22 Jun 2012 20:34:20 -0400 Received: by mail-pz0-f45.google.com with SMTP id n2so3053134dad.4 for ; Fri, 22 Jun 2012 17:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=5nYB/QlfsDBy9crQ4cVm7z9suPHJcqsfGasib8zt3i0=; b=S2ohuEXkTo6By94rExhtGxmlKPzxpHelE4RsdE2mcJJ2TaeeH55K1VVSs8hiCaYYU+ uCY6v+VuFM9yNVCNLqcFcggg1nKJ1FZWgXT/ohbqORZGtcuJfKmupyO7dVegM7L9gaS3 jtIMduyznmhiPgSjTQGbRa4euGhcyVLw/cIo2kP+PHx39uSJ9YvlFrvGUjKR0GmkWtTh 8QGbcN4SPE8RYB7SO051YxpUv+rZG9hWc8R0jFI6cAYFS1j7uwXjEyXfwC2uIhBTZ8XD PP+3cHxOySGK3HobalC6Lnk9rS1XbgjRkctj8076ObI+istYGy2t909EW3O6MPrHVzio Bntg== Received: by 10.68.212.138 with SMTP id nk10mr15290102pbc.93.1340411658970; Fri, 22 Jun 2012 17:34:18 -0700 (PDT) Received: from localhost.localdomain ([32.97.110.59]) by mx.google.com with ESMTPS id os1sm630169pbb.49.2012.06.22.17.34.16 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 22 Jun 2012 17:34:17 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Fri, 22 Jun 2012 19:33:16 -0500 Message-Id: <1340411610-22596-13-git-send-email-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1340411610-22596-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1340411610-22596-1-git-send-email-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.210.45 Cc: aliguori@us.ibm.com Subject: [Qemu-devel] [PATCH stable-1.1 12/26] kvm/apic: correct short memset X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jim Meyering kvm_put_apic_state's attempt to clear *kapic before setting its bits cleared sizeof(void*) bytes (no more than 8) rather than the intended 1024 (KVM_APIC_REG_SIZE) bytes. Spotted by coverity. Signed-off-by: Jim Meyering Signed-off-by: Avi Kivity --- hw/kvm/apic.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/kvm/apic.c b/hw/kvm/apic.c index ffe7a52..a0ab503 100644 --- a/hw/kvm/apic.c +++ b/hw/kvm/apic.c @@ -29,7 +29,7 @@ void kvm_put_apic_state(DeviceState *d, struct kvm_lapic_state *kapic) APICCommonState *s = DO_UPCAST(APICCommonState, busdev.qdev, d); int i; - memset(kapic, 0, sizeof(kapic)); + memset(kapic, 0, sizeof(*kapic)); kvm_apic_set_reg(kapic, 0x2, s->id << 24); kvm_apic_set_reg(kapic, 0x8, s->tpr); kvm_apic_set_reg(kapic, 0xd, s->log_dest << 24);