From patchwork Thu May 24 15:26:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 161153 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D932EB6FCC for ; Fri, 25 May 2012 01:27:26 +1000 (EST) Received: from localhost ([::1]:33879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXZwi-0005if-68 for incoming@patchwork.ozlabs.org; Thu, 24 May 2012 11:27:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXZwU-0005hA-Aj for qemu-devel@nongnu.org; Thu, 24 May 2012 11:27:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXZwN-0007SE-PR for qemu-devel@nongnu.org; Thu, 24 May 2012 11:27:09 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:36893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXZwN-0007QL-Gy for qemu-devel@nongnu.org; Thu, 24 May 2012 11:27:03 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 24 May 2012 16:26:58 +0100 Received: from d06nrmr1307.portsmouth.uk.ibm.com (9.149.38.129) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 24 May 2012 16:26:56 +0100 Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4OFQtJQ2449446 for ; Thu, 24 May 2012 16:26:55 +0100 Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4OFIZ5s015732 for ; Thu, 24 May 2012 11:18:36 -0400 Received: from localhost (stefanha-thinkpad.manchester-maybrook.uk.ibm.com [9.174.219.145]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q4OFIZ9t015720; Thu, 24 May 2012 11:18:35 -0400 From: Stefan Hajnoczi To: Date: Thu, 24 May 2012 16:26:51 +0100 Message-Id: <1337873211-16124-1-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.10 x-cbid: 12052415-4966-0000-0000-0000026B4A08 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 195.75.94.106 Cc: Kevin Wolf , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH] qemu-iotests: mark 035 qcow2-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The 035 parallel aio write test relies on knowledge of qcow2 metadata layout to stress parallel L2 table accesses. This only works for qcow2 unless we add additional calculations for qed or other formats. Mark this test as qcow2-only. Note that the test is strictly speaking non-deterministic although the output produced is reliable with qcow2. This is because the aio_write command returns before the aio write request has completed. Completions can occur at any time afterwards and cause a message to be printed. Therefore the exact output of this test is not deterministic but we seem to get away with it for qcow2 (maybe due to coroutine and main loop scheduling). Signed-off-by: Stefan Hajnoczi --- I was originally going to filter out the "qemu-io> " prompt so that non-determinism is not an issue. But it turns out that aio write completion messages can be printed at any time too. Short of sorting the output before golden master comparison, we don't have a good solution here. Sorting output would be confusing since we normally don't do that in other tests. tests/qemu-iotests/035 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/035 b/tests/qemu-iotests/035 index 56616a1..9d2d347 100755 --- a/tests/qemu-iotests/035 +++ b/tests/qemu-iotests/035 @@ -39,7 +39,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 . ./common.rc . ./common.filter -_supported_fmt generic +_supported_fmt qcow2 _supported_proto generic _supported_os Linux