From patchwork Thu Apr 19 02:39:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhiyong Wu X-Patchwork-Id: 153638 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 13B71B6F62 for ; Thu, 19 Apr 2012 13:34:36 +1000 (EST) Received: from localhost ([::1]:60076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKi8f-0004MV-IO for incoming@patchwork.ozlabs.org; Wed, 18 Apr 2012 23:34:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKhIH-0003n4-P9 for qemu-devel@nongnu.org; Wed, 18 Apr 2012 22:40:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SKhIF-0002MS-Dv for qemu-devel@nongnu.org; Wed, 18 Apr 2012 22:40:25 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:39973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKhIF-0002MC-6H for qemu-devel@nongnu.org; Wed, 18 Apr 2012 22:40:23 -0400 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 18 Apr 2012 20:40:21 -0600 Received: from d01dlp03.pok.ibm.com (9.56.224.17) by e35.co.us.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 18 Apr 2012 20:40:09 -0600 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id BD995C9005A for ; Wed, 18 Apr 2012 22:40:07 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q3J2e8S23043428 for ; Wed, 18 Apr 2012 22:40:08 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q3J2e7Sr024851 for ; Wed, 18 Apr 2012 23:40:08 -0300 Received: from us.ibm.com (f15.cn.ibm.com [9.115.118.120] (may be forged)) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q3J2e3kc024067; Wed, 18 Apr 2012 23:40:04 -0300 Received: by us.ibm.com (sSMTP sendmail emulation); Thu, 19 Apr 2012 10:40:01 +0800 From: zwu.kernel@gmail.com To: qemu-devel@nongnu.org Date: Thu, 19 Apr 2012 10:39:03 +0800 Message-Id: <1334803149-27379-11-git-send-email-zwu.kernel@gmail.com> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1334803149-27379-1-git-send-email-zwu.kernel@gmail.com> References: <1334803149-27379-1-git-send-email-zwu.kernel@gmail.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12041902-6148-0000-0000-00000526F1A5 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 32.97.110.153 Cc: stefanha@linux.vnet.ibm.com, linuxram@us.ibm.com, nab@linux-iscsi.org, zwu.kernel@gmail.com, luowenj@cn.ibm.com, pbonzini@redhat.com Subject: [Qemu-devel] [PATCH 10/16] virtio-pci: check that event notification worked X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Stefan Hajnoczi For sanity assert that event notification succeeds. Signed-off-by: Stefan Hajnoczi --- hw/virtio-pci.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index dcd58d0..025a518 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -293,8 +293,11 @@ static void virtio_pci_queue_notify(VirtIOPCIProxy *proxy, uint32_t n) vq = virtio_get_queue(proxy->vdev, n); notifier = virtio_queue_get_host_notifier(vq); if (event_notifier_valid(notifier)) { + int r; + printf("notifying vq %u host notifier from userspace\n", n); - event_notifier_notify(notifier); + r = event_notifier_notify(notifier); + assert(r == 0); } else { virtio_queue_notify_vq(vq); }