diff mbox

[V10,2/8] configure: Introduce --enable-xen-pci-passthrough.

Message ID 1332934907-24080-3-git-send-email-anthony.perard@citrix.com
State New
Headers show

Commit Message

Anthony PERARD March 28, 2012, 11:41 a.m. UTC 
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 configure |   25 +++++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)

Comments

Konrad Rzeszutek Wilk March 28, 2012, 6:52 p.m. UTC | #1 
On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>


Reviewed-by: me.

> ---
>  configure |   25 +++++++++++++++++++++++++
>  1 files changed, 25 insertions(+), 0 deletions(-)
> 
> diff --git a/configure b/configure
> index 14ef738..cb7bc75 100755
> --- a/configure
> +++ b/configure
> @@ -136,6 +136,7 @@ vnc_png=""
>  vnc_thread="no"
>  xen=""
>  xen_ctrl_version=""
> +xen_pci_passthrough=""
>  linux_aio=""
>  cap_ng=""
>  attr=""
> @@ -682,6 +683,10 @@ for opt do
>    ;;
>    --enable-xen) xen="yes"
>    ;;
> +  --disable-xen-pci-passthrough) xen_pci_passthrough="no"
> +  ;;
> +  --enable-xen-pci-passthrough) xen_pci_passthrough="yes"
> +  ;;
>    --disable-brlapi) brlapi="no"
>    ;;
>    --enable-brlapi) brlapi="yes"
> @@ -1034,6 +1039,8 @@ echo "                           (affects only QEMU, not qemu-img)"
>  echo "  --enable-mixemu          enable mixer emulation"
>  echo "  --disable-xen            disable xen backend driver support"
>  echo "  --enable-xen             enable xen backend driver support"
> +echo "  --disable-xen-pci-passthrough"
> +echo "  --enable-xen-pci-passthrough"
>  echo "  --disable-brlapi         disable BrlAPI"
>  echo "  --enable-brlapi          enable BrlAPI"
>  echo "  --disable-vnc-tls        disable TLS encryption for VNC server"
> @@ -1478,6 +1485,21 @@ EOF
>    fi
>  fi
>  
> +if test "$xen_pci_passthrough" != "no"; then
> +  if test "$xen" = "yes" && test "$linux" = "yes"; then
> +    xen_pci_passthrough=yes
> +  else
> +    if test "$xen_pci_passthrough" = "yes"; then
> +      echo "ERROR"
> +      echo "ERROR: User requested feature Xen PCI Passthrough"
> +      echo "ERROR: but this feature require /sys from Linux"
> +      echo "ERROR"
> +      exit 1;
> +    fi
> +    xen_pci_passthrough=no
> +  fi
> +fi
> +
>  ##########################################
>  # pkg-config probe
>  
> @@ -3635,6 +3657,9 @@ case "$target_arch2" in
>      if test "$xen" = "yes" -a "$target_softmmu" = "yes" ; then
>        target_phys_bits=64
>        echo "CONFIG_XEN=y" >> $config_target_mak
> +      if test "$xen_pci_passthrough" = yes; then
> +        echo "CONFIG_XEN_PCI_PASSTHROUGH=y" >> "$config_target_mak"
> +      fi
>      else
>        echo "CONFIG_NO_XEN=y" >> $config_target_mak
>      fi
> -- 
> Anthony PERARD
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
Anthony Liguori March 28, 2012, 9:02 p.m. UTC | #2 
On 03/28/2012 01:52 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote:
>> Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
>> Acked-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>
>
> Reviewed-by: me.

FYI, the scripts that I use to manage patches will collect Reviewed-by's and put 
them in the commit message so there's a proper review history in git.

But 'Reviewed-by: me.' will lose it's context and your review will be forever 
lost to git history :-)

So please use the proper tags.

Regards,

Anthony Liguori

>
>> ---
>>   configure |   25 +++++++++++++++++++++++++
>>   1 files changed, 25 insertions(+), 0 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 14ef738..cb7bc75 100755
>> --- a/configure
>> +++ b/configure
>> @@ -136,6 +136,7 @@ vnc_png=""
>>   vnc_thread="no"
>>   xen=""
>>   xen_ctrl_version=""
>> +xen_pci_passthrough=""
>>   linux_aio=""
>>   cap_ng=""
>>   attr=""
>> @@ -682,6 +683,10 @@ for opt do
>>     ;;
>>     --enable-xen) xen="yes"
>>     ;;
>> +  --disable-xen-pci-passthrough) xen_pci_passthrough="no"
>> +  ;;
>> +  --enable-xen-pci-passthrough) xen_pci_passthrough="yes"
>> +  ;;
>>     --disable-brlapi) brlapi="no"
>>     ;;
>>     --enable-brlapi) brlapi="yes"
>> @@ -1034,6 +1039,8 @@ echo "                           (affects only QEMU, not qemu-img)"
>>   echo "  --enable-mixemu          enable mixer emulation"
>>   echo "  --disable-xen            disable xen backend driver support"
>>   echo "  --enable-xen             enable xen backend driver support"
>> +echo "  --disable-xen-pci-passthrough"
>> +echo "  --enable-xen-pci-passthrough"
>>   echo "  --disable-brlapi         disable BrlAPI"
>>   echo "  --enable-brlapi          enable BrlAPI"
>>   echo "  --disable-vnc-tls        disable TLS encryption for VNC server"
>> @@ -1478,6 +1485,21 @@ EOF
>>     fi
>>   fi
>>
>> +if test "$xen_pci_passthrough" != "no"; then
>> +  if test "$xen" = "yes"&&  test "$linux" = "yes"; then
>> +    xen_pci_passthrough=yes
>> +  else
>> +    if test "$xen_pci_passthrough" = "yes"; then
>> +      echo "ERROR"
>> +      echo "ERROR: User requested feature Xen PCI Passthrough"
>> +      echo "ERROR: but this feature require /sys from Linux"
>> +      echo "ERROR"
>> +      exit 1;
>> +    fi
>> +    xen_pci_passthrough=no
>> +  fi
>> +fi
>> +
>>   ##########################################
>>   # pkg-config probe
>>
>> @@ -3635,6 +3657,9 @@ case "$target_arch2" in
>>       if test "$xen" = "yes" -a "$target_softmmu" = "yes" ; then
>>         target_phys_bits=64
>>         echo "CONFIG_XEN=y">>  $config_target_mak
>> +      if test "$xen_pci_passthrough" = yes; then
>> +        echo "CONFIG_XEN_PCI_PASSTHROUGH=y">>  "$config_target_mak"
>> +      fi
>>       else
>>         echo "CONFIG_NO_XEN=y">>  $config_target_mak
>>       fi
>> --
>> Anthony PERARD
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
>
Konrad Rzeszutek Wilk March 28, 2012, 9:07 p.m. UTC | #3 
On Wed, Mar 28, 2012 at 04:02:04PM -0500, Anthony Liguori wrote:
> On 03/28/2012 01:52 PM, Konrad Rzeszutek Wilk wrote:
> >On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote:
> >>Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
> >>Acked-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
> >
> >
> >Reviewed-by: me.
> 
> FYI, the scripts that I use to manage patches will collect
> Reviewed-by's and put them in the commit message so there's a proper
> review history in git.
> 
> But 'Reviewed-by: me.' will lose it's context and your review will
> be forever lost to git history :-)

I figured that Anthony would repost the patch set and stick my proper name
in it...
> 
> So please use the proper tags.
> 
> Regards,
> 
> Anthony Liguori
> 
> >
> >>---
> >>  configure |   25 +++++++++++++++++++++++++
> >>  1 files changed, 25 insertions(+), 0 deletions(-)
> >>
> >>diff --git a/configure b/configure
> >>index 14ef738..cb7bc75 100755
> >>--- a/configure
> >>+++ b/configure
> >>@@ -136,6 +136,7 @@ vnc_png=""
> >>  vnc_thread="no"
> >>  xen=""
> >>  xen_ctrl_version=""
> >>+xen_pci_passthrough=""
> >>  linux_aio=""
> >>  cap_ng=""
> >>  attr=""
> >>@@ -682,6 +683,10 @@ for opt do
> >>    ;;
> >>    --enable-xen) xen="yes"
> >>    ;;
> >>+  --disable-xen-pci-passthrough) xen_pci_passthrough="no"
> >>+  ;;
> >>+  --enable-xen-pci-passthrough) xen_pci_passthrough="yes"
> >>+  ;;
> >>    --disable-brlapi) brlapi="no"
> >>    ;;
> >>    --enable-brlapi) brlapi="yes"
> >>@@ -1034,6 +1039,8 @@ echo "                           (affects only QEMU, not qemu-img)"
> >>  echo "  --enable-mixemu          enable mixer emulation"
> >>  echo "  --disable-xen            disable xen backend driver support"
> >>  echo "  --enable-xen             enable xen backend driver support"
> >>+echo "  --disable-xen-pci-passthrough"
> >>+echo "  --enable-xen-pci-passthrough"
> >>  echo "  --disable-brlapi         disable BrlAPI"
> >>  echo "  --enable-brlapi          enable BrlAPI"
> >>  echo "  --disable-vnc-tls        disable TLS encryption for VNC server"
> >>@@ -1478,6 +1485,21 @@ EOF
> >>    fi
> >>  fi
> >>
> >>+if test "$xen_pci_passthrough" != "no"; then
> >>+  if test "$xen" = "yes"&&  test "$linux" = "yes"; then
> >>+    xen_pci_passthrough=yes
> >>+  else
> >>+    if test "$xen_pci_passthrough" = "yes"; then
> >>+      echo "ERROR"
> >>+      echo "ERROR: User requested feature Xen PCI Passthrough"
> >>+      echo "ERROR: but this feature require /sys from Linux"
> >>+      echo "ERROR"
> >>+      exit 1;
> >>+    fi
> >>+    xen_pci_passthrough=no
> >>+  fi
> >>+fi
> >>+
> >>  ##########################################
> >>  # pkg-config probe
> >>
> >>@@ -3635,6 +3657,9 @@ case "$target_arch2" in
> >>      if test "$xen" = "yes" -a "$target_softmmu" = "yes" ; then
> >>        target_phys_bits=64
> >>        echo "CONFIG_XEN=y">>  $config_target_mak
> >>+      if test "$xen_pci_passthrough" = yes; then
> >>+        echo "CONFIG_XEN_PCI_PASSTHROUGH=y">>  "$config_target_mak"
> >>+      fi
> >>      else
> >>        echo "CONFIG_NO_XEN=y">>  $config_target_mak
> >>      fi
> >>--
> >>Anthony PERARD
> >>
> >>
> >>_______________________________________________
> >>Xen-devel mailing list
> >>Xen-devel@lists.xen.org
> >>http://lists.xen.org/xen-devel
> >
diff mbox

Patch

diff --git a/configure b/configure
index 14ef738..cb7bc75 100755
--- a/configure
+++ b/configure
@@ -136,6 +136,7 @@  vnc_png=""
 vnc_thread="no"
 xen=""
 xen_ctrl_version=""
+xen_pci_passthrough=""
 linux_aio=""
 cap_ng=""
 attr=""
@@ -682,6 +683,10 @@  for opt do
   ;;
   --enable-xen) xen="yes"
   ;;
+  --disable-xen-pci-passthrough) xen_pci_passthrough="no"
+  ;;
+  --enable-xen-pci-passthrough) xen_pci_passthrough="yes"
+  ;;
   --disable-brlapi) brlapi="no"
   ;;
   --enable-brlapi) brlapi="yes"
@@ -1034,6 +1039,8 @@  echo "                           (affects only QEMU, not qemu-img)"
 echo "  --enable-mixemu          enable mixer emulation"
 echo "  --disable-xen            disable xen backend driver support"
 echo "  --enable-xen             enable xen backend driver support"
+echo "  --disable-xen-pci-passthrough"
+echo "  --enable-xen-pci-passthrough"
 echo "  --disable-brlapi         disable BrlAPI"
 echo "  --enable-brlapi          enable BrlAPI"
 echo "  --disable-vnc-tls        disable TLS encryption for VNC server"
@@ -1478,6 +1485,21 @@  EOF
   fi
 fi
 
+if test "$xen_pci_passthrough" != "no"; then
+  if test "$xen" = "yes" && test "$linux" = "yes"; then
+    xen_pci_passthrough=yes
+  else
+    if test "$xen_pci_passthrough" = "yes"; then
+      echo "ERROR"
+      echo "ERROR: User requested feature Xen PCI Passthrough"
+      echo "ERROR: but this feature require /sys from Linux"
+      echo "ERROR"
+      exit 1;
+    fi
+    xen_pci_passthrough=no
+  fi
+fi
+
 ##########################################
 # pkg-config probe
 
@@ -3635,6 +3657,9 @@  case "$target_arch2" in
     if test "$xen" = "yes" -a "$target_softmmu" = "yes" ; then
       target_phys_bits=64
       echo "CONFIG_XEN=y" >> $config_target_mak
+      if test "$xen_pci_passthrough" = yes; then
+        echo "CONFIG_XEN_PCI_PASSTHROUGH=y" >> "$config_target_mak"
+      fi
     else
       echo "CONFIG_NO_XEN=y" >> $config_target_mak
     fi