Message ID | 1329609944.90569.YahooMailClassic@web110415.mail.gq1.yahoo.com |
---|---|
State | New |
Headers | show |
Am 19.02.2012 01:05, schrieb Kenneth Salerno: > Hello, > > The VERSION file in stable release qemu-1.0.1 has what I believe might be a typo: "1.0,1" rather than "1.0.1". This is causing a parsing issue for windres.exe in Win32 which chokes on: > #define CONFIG_FILEVERSION 1,0,1,0,1,0 > #define CONFIG_PRODUCTVERSION 1,0,1,0,1,0 > > when it should be seeing this: > #define CONFIG_FILEVERSION 1,0,1,0 > #define CONFIG_PRODUCTVERSION 1,0,1,0 > > > Patch: > --- VERSION.ORIG 2012-02-18 18:56:16.625000000 -0500 > +++ VERSION 2012-02-18 18:56:31.609375000 -0500 > @@ -1 +1 @@ > -1.0,1 > +1.0.1 Acked-by: Stefan Weil <sw@weilnetz.de>
On Sun, Feb 19, 2012 at 11:51:25AM +0100, Stefan Weil wrote: > Am 19.02.2012 01:05, schrieb Kenneth Salerno: > >Hello, > > > >The VERSION file in stable release qemu-1.0.1 has what I believe might be a typo: "1.0,1" rather than "1.0.1". This is causing a parsing issue for windres.exe in Win32 which chokes on: > > #define CONFIG_FILEVERSION 1,0,1,0,1,0 > > #define CONFIG_PRODUCTVERSION 1,0,1,0,1,0 > > > >when it should be seeing this: > > #define CONFIG_FILEVERSION 1,0,1,0 > > #define CONFIG_PRODUCTVERSION 1,0,1,0 > > > > > >Patch: > >--- VERSION.ORIG 2012-02-18 18:56:16.625000000 -0500 > >+++ VERSION 2012-02-18 18:56:31.609375000 -0500 > >@@ -1 +1 @@ > >-1.0,1 > >+1.0.1 > > Acked-by: Stefan Weil <sw@weilnetz.de> Ack, wow do I feel silly. Thanks for the catch.
--- VERSION.ORIG 2012-02-18 18:56:16.625000000 -0500 +++ VERSION 2012-02-18 18:56:31.609375000 -0500 @@ -1 +1 @@ -1.0,1 +1.0.1