diff mbox

[V7,03/11] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE

Message ID 1329498525-8454-4-git-send-email-anthony.perard@citrix.com
State New
Headers show

Commit Message

Anthony PERARD Feb. 17, 2012, 5:08 p.m. UTC
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 hw/pci_regs.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Michael S. Tsirkin Feb. 20, 2012, 8:30 p.m. UTC | #1
On Fri, Feb 17, 2012 at 05:08:37PM +0000, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  hw/pci_regs.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/pci_regs.h b/hw/pci_regs.h
> index 6b42515..56a404b 100644
> --- a/hw/pci_regs.h
> +++ b/hw/pci_regs.h
> @@ -392,6 +392,7 @@
>  #define  PCI_EXP_TYPE_UPSTREAM	0x5	/* Upstream Port */
>  #define  PCI_EXP_TYPE_DOWNSTREAM 0x6	/* Downstream Port */
>  #define  PCI_EXP_TYPE_PCI_BRIDGE 0x7	/* PCI/PCI-X Bridge */
> +#define  PCI_EXP_TYPE_PCIE_BRIDGE 0x8   /* PCI/PCI-X to PCIE Bridge */

I don't know why but linux source lacks this value, and we
try to stay in sync with that.
Please push there then we'll add here.
Meanwhile  put a define in your code.

>  #define  PCI_EXP_TYPE_RC_END	0x9	/* Root Complex Integrated Endpoint */
>  #define  PCI_EXP_TYPE_RC_EC     0xa     /* Root Complex Event Collector */
>  #define PCI_EXP_FLAGS_SLOT	0x0100	/* Slot implemented */
> -- 
> Anthony PERARD
>
Anthony PERARD Feb. 21, 2012, 4:07 p.m. UTC | #2
On Mon, Feb 20, 2012 at 20:30, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Fri, Feb 17, 2012 at 05:08:37PM +0000, Anthony PERARD wrote:
>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>> ---
>>  hw/pci_regs.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/pci_regs.h b/hw/pci_regs.h
>> index 6b42515..56a404b 100644
>> --- a/hw/pci_regs.h
>> +++ b/hw/pci_regs.h
>> @@ -392,6 +392,7 @@
>>  #define  PCI_EXP_TYPE_UPSTREAM       0x5     /* Upstream Port */
>>  #define  PCI_EXP_TYPE_DOWNSTREAM 0x6 /* Downstream Port */
>>  #define  PCI_EXP_TYPE_PCI_BRIDGE 0x7 /* PCI/PCI-X Bridge */
>> +#define  PCI_EXP_TYPE_PCIE_BRIDGE 0x8   /* PCI/PCI-X to PCIE Bridge */
>
> I don't know why but linux source lacks this value, and we
> try to stay in sync with that.
> Please push there then we'll add here.
> Meanwhile  put a define in your code.

Ok, I'll do that.
Thanks,
Michael S. Tsirkin Feb. 23, 2012, 8:20 p.m. UTC | #3
On Fri, Feb 17, 2012 at 05:08:37PM +0000, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Applied, thanks.

> ---
>  hw/pci_regs.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/pci_regs.h b/hw/pci_regs.h
> index 6b42515..56a404b 100644
> --- a/hw/pci_regs.h
> +++ b/hw/pci_regs.h
> @@ -392,6 +392,7 @@
>  #define  PCI_EXP_TYPE_UPSTREAM	0x5	/* Upstream Port */
>  #define  PCI_EXP_TYPE_DOWNSTREAM 0x6	/* Downstream Port */
>  #define  PCI_EXP_TYPE_PCI_BRIDGE 0x7	/* PCI/PCI-X Bridge */
> +#define  PCI_EXP_TYPE_PCIE_BRIDGE 0x8   /* PCI/PCI-X to PCIE Bridge */
>  #define  PCI_EXP_TYPE_RC_END	0x9	/* Root Complex Integrated Endpoint */
>  #define  PCI_EXP_TYPE_RC_EC     0xa     /* Root Complex Event Collector */
>  #define PCI_EXP_FLAGS_SLOT	0x0100	/* Slot implemented */
> -- 
> Anthony PERARD
>
diff mbox

Patch

diff --git a/hw/pci_regs.h b/hw/pci_regs.h
index 6b42515..56a404b 100644
--- a/hw/pci_regs.h
+++ b/hw/pci_regs.h
@@ -392,6 +392,7 @@ 
 #define  PCI_EXP_TYPE_UPSTREAM	0x5	/* Upstream Port */
 #define  PCI_EXP_TYPE_DOWNSTREAM 0x6	/* Downstream Port */
 #define  PCI_EXP_TYPE_PCI_BRIDGE 0x7	/* PCI/PCI-X Bridge */
+#define  PCI_EXP_TYPE_PCIE_BRIDGE 0x8   /* PCI/PCI-X to PCIE Bridge */
 #define  PCI_EXP_TYPE_RC_END	0x9	/* Root Complex Integrated Endpoint */
 #define  PCI_EXP_TYPE_RC_EC     0xa     /* Root Complex Event Collector */
 #define PCI_EXP_FLAGS_SLOT	0x0100	/* Slot implemented */