| Message ID | 1326674823-13069-3-git-send-email-afaerber@suse.de |
|---|---|
| State | New |
| Headers | show |
On Mon, Jan 16, 2012 at 00:46, Andreas Färber <afaerber@suse.de> wrote: > Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc: > Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint64 > type. > > Use uint64_t instead. > > Signed-off-by: Andreas Färber <afaerber@suse.de> > Cc: Richard Henderson <rth@twiddle.net> > Cc: Blue Swirl <blauwirbel@gmail.com> Good catch, Reviewed-by: Blue Swirl <blauwirbel@gmail.com> > --- > target-sparc/vis_helper.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-sparc/vis_helper.c b/target-sparc/vis_helper.c > index a992c29..9d2edb0 100644 > --- a/target-sparc/vis_helper.c > +++ b/target-sparc/vis_helper.c > @@ -459,7 +459,7 @@ uint32_t helper_fpackfix(uint64_t gsr, uint64_t rs2) > return ret; > } > > -uint64 helper_bshuffle(uint64_t gsr, uint64_t src1, uint64_t src2) > +uint64_t helper_bshuffle(uint64_t gsr, uint64_t src1, uint64_t src2) > { > union { > uint64_t ll[2]; > -- > 1.7.7 >
Am 21.01.2012 19:51, schrieb Blue Swirl: > On Mon, Jan 16, 2012 at 00:46, Andreas Färber <afaerber@suse.de> wrote: >> Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc: >> Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint64 >> type. >> >> Use uint64_t instead. >> >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> Cc: Richard Henderson <rth@twiddle.net> >> Cc: Blue Swirl <blauwirbel@gmail.com> > > Good catch, > Reviewed-by: Blue Swirl <blauwirbel@gmail.com> Feel free to apply this patch if Richard doesn't comment. The rest of the series needs some more review and benchmarking. Is there maybe a way to poison these types outside fpu/ meanwhile? Andreas
On Sun, Jan 22, 2012 at 02:03, Andreas Färber <afaerber@suse.de> wrote: > Am 21.01.2012 19:51, schrieb Blue Swirl: >> On Mon, Jan 16, 2012 at 00:46, Andreas Färber <afaerber@suse.de> wrote: >>> Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc: >>> Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint64 >>> type. >>> >>> Use uint64_t instead. >>> >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >>> Cc: Richard Henderson <rth@twiddle.net> >>> Cc: Blue Swirl <blauwirbel@gmail.com> >> >> Good catch, >> Reviewed-by: Blue Swirl <blauwirbel@gmail.com> > > Feel free to apply this patch if Richard doesn't comment. The rest of > the series needs some more review and benchmarking. > > Is there maybe a way to poison these types outside fpu/ meanwhile? Maybe there could be, but wasn't one part of the problem that OSX uses the same type names?
On Mon, Jan 16, 2012 at 00:46, Andreas Färber <afaerber@suse.de> wrote: > Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc: > Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint64 > type. > > Use uint64_t instead. > > Signed-off-by: Andreas Färber <afaerber@suse.de> > Cc: Richard Henderson <rth@twiddle.net> > Cc: Blue Swirl <blauwirbel@gmail.com> Thanks, applied. > --- > target-sparc/vis_helper.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-sparc/vis_helper.c b/target-sparc/vis_helper.c > index a992c29..9d2edb0 100644 > --- a/target-sparc/vis_helper.c > +++ b/target-sparc/vis_helper.c > @@ -459,7 +459,7 @@ uint32_t helper_fpackfix(uint64_t gsr, uint64_t rs2) > return ret; > } > > -uint64 helper_bshuffle(uint64_t gsr, uint64_t src1, uint64_t src2) > +uint64_t helper_bshuffle(uint64_t gsr, uint64_t src1, uint64_t src2) > { > union { > uint64_t ll[2]; > -- > 1.7.7 >
diff --git a/target-sparc/vis_helper.c b/target-sparc/vis_helper.c index a992c29..9d2edb0 100644 --- a/target-sparc/vis_helper.c +++ b/target-sparc/vis_helper.c @@ -459,7 +459,7 @@ uint32_t helper_fpackfix(uint64_t gsr, uint64_t rs2) return ret; } -uint64 helper_bshuffle(uint64_t gsr, uint64_t src1, uint64_t src2) +uint64_t helper_bshuffle(uint64_t gsr, uint64_t src1, uint64_t src2) { union { uint64_t ll[2];
Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc: Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint64 type. Use uint64_t instead. Signed-off-by: Andreas Färber <afaerber@suse.de> Cc: Richard Henderson <rth@twiddle.net> Cc: Blue Swirl <blauwirbel@gmail.com> --- target-sparc/vis_helper.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)