From patchwork Fri Jan 13 10:51:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 135782 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 068C2B6EF7 for ; Fri, 13 Jan 2012 21:52:25 +1100 (EST) Received: from localhost ([::1]:42374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlek9-0004e2-VB for incoming@patchwork.ozlabs.org; Fri, 13 Jan 2012 05:52:21 -0500 Received: from eggs.gnu.org ([140.186.70.92]:42186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlejq-0004Ae-Gx for qemu-devel@nongnu.org; Fri, 13 Jan 2012 05:52:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rlejk-000195-9x for qemu-devel@nongnu.org; Fri, 13 Jan 2012 05:52:02 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:51178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlejj-00018r-Vm for qemu-devel@nongnu.org; Fri, 13 Jan 2012 05:51:56 -0500 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Jan 2012 10:51:54 -0000 Received: from d06nrmr1407.portsmouth.uk.ibm.com ([9.149.38.185]) by e06smtp13.uk.ibm.com ([192.168.101.143]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 13 Jan 2012 10:51:49 -0000 Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0DApnvb1777874 for ; Fri, 13 Jan 2012 10:51:49 GMT Received: from d06av12.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0DApmOF000989 for ; Fri, 13 Jan 2012 03:51:49 -0700 Received: from localhost (stefanha-thinkpad.manchester-maybrook.uk.ibm.com [9.174.219.31]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q0DApmr1000979; Fri, 13 Jan 2012 03:51:48 -0700 From: Stefan Hajnoczi To: Anthony Liguori Date: Fri, 13 Jan 2012 10:51:30 +0000 Message-Id: <1326451900-18325-3-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.7.3 In-Reply-To: <1326451900-18325-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1326451900-18325-1-git-send-email-stefanha@linux.vnet.ibm.com> x-cbid: 12011310-2966-0000-0000-000002E03C20 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 195.75.94.109 Cc: qemu-devel@nongnu.org, Aurelien Jarno , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 02/12] tcg-arm: fix a typo in comments X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Aurelien Jarno ARM still doesn't support 16GB buffers in 32-bit modes, replace the 16GB by 16MB in the comment. Reviewed-by: Peter Maydell Signed-off-by: Aurelien Jarno Signed-off-by: Stefan Hajnoczi --- exec.c | 2 +- tcg/arm/tcg-target.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index b1d6602..7f9f730 100644 --- a/exec.c +++ b/exec.c @@ -511,7 +511,7 @@ static void code_gen_alloc(unsigned long tb_size) if (code_gen_buffer_size > (512 * 1024 * 1024)) code_gen_buffer_size = (512 * 1024 * 1024); #elif defined(__arm__) - /* Keep the buffer no bigger than 16GB to branch between blocks */ + /* Keep the buffer no bigger than 16MB to branch between blocks */ if (code_gen_buffer_size > 16 * 1024 * 1024) code_gen_buffer_size = 16 * 1024 * 1024; #elif defined(__s390x__) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 1d32798..5b233f5 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -843,7 +843,7 @@ static inline void tcg_out_st8(TCGContext *s, int cond, } /* The _goto case is normally between TBs within the same code buffer, - * and with the code buffer limited to 16GB we shouldn't need the long + * and with the code buffer limited to 16MB we shouldn't need the long * case. * * .... except to the prologue that is in its own buffer.