From patchwork Tue Dec 6 11:00:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 129618 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EDE1B1007D5 for ; Tue, 6 Dec 2011 22:04:13 +1100 (EST) Received: from localhost ([::1]:57555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXsoh-0005zU-Ht for incoming@patchwork.ozlabs.org; Tue, 06 Dec 2011 06:04:07 -0500 Received: from eggs.gnu.org ([140.186.70.92]:41425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXsoJ-0005bp-5w for qemu-devel@nongnu.org; Tue, 06 Dec 2011 06:03:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXsoH-0005vi-JA for qemu-devel@nongnu.org; Tue, 06 Dec 2011 06:03:43 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:46935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXsoH-0005uC-AQ for qemu-devel@nongnu.org; Tue, 06 Dec 2011 06:03:41 -0500 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 6 Dec 2011 11:03:40 -0000 Received: from d06nrmr1806.portsmouth.uk.ibm.com ([9.149.39.193]) by e06smtp10.uk.ibm.com ([192.168.101.140]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 6 Dec 2011 11:03:25 -0000 Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pB6B3PTD2793684 for ; Tue, 6 Dec 2011 11:03:25 GMT Received: from d06av09.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pB6B3O5D025362 for ; Tue, 6 Dec 2011 04:03:24 -0700 Received: from localhost (stefanha-thinkpad.manchester-maybrook.uk.ibm.com [9.174.219.31]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id pB6B3Ok5025341; Tue, 6 Dec 2011 04:03:24 -0700 From: Stefan Hajnoczi To: Date: Tue, 6 Dec 2011 11:00:57 +0000 Message-Id: <1323169274-31657-3-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.7.3 In-Reply-To: <1323169274-31657-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1323169274-31657-1-git-send-email-stefanha@linux.vnet.ibm.com> x-cbid: 11120611-4966-0000-0000-000000C30F8B X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 195.75.94.106 Cc: Anthony Liguori , Markus Armbruster , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 02/19] console: Fix console_putchar() for CSI J X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Markus Armbruster It falls through to the code for CSI K. "Erase Down" also does "Erase End of Line", "Erase Up" also does "Erase Start of Line", and "Erase Screen" also does "Erase Line". Happens not to be visible. Fix it anyway. Spotted by Coverity. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- console.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/console.c b/console.c index 374fcba..ce0429d 100644 --- a/console.c +++ b/console.c @@ -1011,6 +1011,7 @@ static void console_putchar(TextConsole *s, int ch) } break; } + break; case 'K': switch (s->esc_params[0]) { case 0: