From patchwork Wed Oct 26 14:22:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 121909 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id F1D211007DB for ; Thu, 27 Oct 2011 01:22:49 +1100 (EST) Received: from localhost ([::1]:59612 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ4NK-0000Ph-Np for incoming@patchwork.ozlabs.org; Wed, 26 Oct 2011 10:22:38 -0400 Received: from eggs.gnu.org ([140.186.70.92]:50459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ4NE-0000PO-R3 for qemu-devel@nongnu.org; Wed, 26 Oct 2011 10:22:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJ4ND-0008Vv-Pt for qemu-devel@nongnu.org; Wed, 26 Oct 2011 10:22:32 -0400 Received: from mtagate3.uk.ibm.com ([194.196.100.163]:50253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ4ND-0008UR-Ir for qemu-devel@nongnu.org; Wed, 26 Oct 2011 10:22:31 -0400 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate3.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p9QEMOsw028111 for ; Wed, 26 Oct 2011 14:22:24 GMT Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p9QEMO612232430 for ; Wed, 26 Oct 2011 15:22:24 +0100 Received: from d06av12.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p9QEMNo4029337 for ; Wed, 26 Oct 2011 08:22:24 -0600 Received: from localhost (sig-9-146-169-43.uk.ibm.com [9.146.169.43]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p9QEMN9F029318; Wed, 26 Oct 2011 08:22:23 -0600 From: Stefan Hajnoczi To: Date: Wed, 26 Oct 2011 15:22:06 +0100 Message-Id: <1319638933-19063-4-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1319638933-19063-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1319638933-19063-1-git-send-email-stefanha@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 194.196.100.163 Cc: Anthony Liguori , Stefan Hajnoczi , Pavel Borzenkov Subject: [Qemu-devel] [PATCH 03/10] vmdk: vmdk_read_cid returns garbage if p_name is NULL X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Pavel Borzenkov Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 3969131..a75dcc2 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -207,7 +207,7 @@ static void vmdk_free_last_extent(BlockDriverState *bs) static uint32_t vmdk_read_cid(BlockDriverState *bs, int parent) { char desc[DESC_SIZE]; - uint32_t cid; + uint32_t cid = 0xffffffff; const char *p_name, *cid_str; size_t cid_str_size; BDRVVmdkState *s = bs->opaque;