From patchwork Thu May 12 20:57:28 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jvrao X-Patchwork-Id: 95365 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C5829B6EF3 for ; Fri, 13 May 2011 07:00:21 +1000 (EST) Received: from localhost ([::1]:58187 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKczb-0003i9-5x for incoming@patchwork.ozlabs.org; Thu, 12 May 2011 17:00:19 -0400 Received: from eggs.gnu.org ([140.186.70.92]:50428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKcxb-0000mA-1Y for qemu-devel@nongnu.org; Thu, 12 May 2011 16:58:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QKcxY-0001nH-Es for qemu-devel@nongnu.org; Thu, 12 May 2011 16:58:15 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:48113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKcxY-0001n4-8d for qemu-devel@nongnu.org; Thu, 12 May 2011 16:58:12 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e34.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p4CKjfaF024264 for ; Thu, 12 May 2011 14:45:41 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p4CKw5GN146216 for ; Thu, 12 May 2011 14:58:06 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4CEvbTv032015 for ; Thu, 12 May 2011 08:57:38 -0600 Received: from oc6675851006.ibm.com (dyn9047029068.beaverton.ibm.com [9.47.29.68]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p4CEvUhM031551; Thu, 12 May 2011 08:57:36 -0600 From: "Venkateswararao Jujjuri (JV)" To: qemu-devel@nongnu.org Date: Thu, 12 May 2011 13:57:28 -0700 Message-Id: <1305233867-4367-7-git-send-email-jvrao@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1305233867-4367-1-git-send-email-jvrao@linux.vnet.ibm.com> References: <1305233867-4367-1-git-send-email-jvrao@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 32.97.110.152 Cc: aliguori@us.ibm.com, "Venkateswararao Jujjuri \(JV\)" , stefanha@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH 06/25] [virtio-9p] coroutines for readlink X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Venkateswararao Jujjuri " --- Makefile.objs | 2 +- hw/9pfs/cofs.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++ hw/9pfs/virtio-9p-coth.h | 3 +- hw/9pfs/virtio-9p.c | 22 ++-------------- 4 files changed, 66 insertions(+), 21 deletions(-) create mode 100644 hw/9pfs/cofs.c diff --git a/Makefile.objs b/Makefile.objs index 96f6a24..36005bb 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -297,7 +297,7 @@ hw-obj-$(CONFIG_SOUND) += $(sound-obj-y) 9pfs-nested-$(CONFIG_VIRTFS) = virtio-9p.o virtio-9p-debug.o 9pfs-nested-$(CONFIG_VIRTFS) += virtio-9p-local.o virtio-9p-xattr.o 9pfs-nested-$(CONFIG_VIRTFS) += virtio-9p-xattr-user.o virtio-9p-posix-acl.o -9pfs-nested-$(CONFIG_VIRTFS) += virtio-9p-coth.o +9pfs-nested-$(CONFIG_VIRTFS) += virtio-9p-coth.o cofs.o hw-obj-$(CONFIG_REALLY_VIRTFS) += $(addprefix 9pfs/, $(9pfs-nested-y)) $(addprefix 9pfs/, $(9pfs-nested-y)): QEMU_CFLAGS+=$(GLIB_CFLAGS) diff --git a/hw/9pfs/cofs.c b/hw/9pfs/cofs.c new file mode 100644 index 0000000..b972561 --- /dev/null +++ b/hw/9pfs/cofs.c @@ -0,0 +1,60 @@ + +/* + * Virtio 9p backend + * + * Copyright IBM, Corp. 2011 + * + * Authors: + * Aneesh Kumar K.V + * + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory. + * + */ + +#include "fsdev/qemu-fsdev.h" +#include "qemu-thread.h" +#include "qemu-coroutine.h" +#include "virtio-9p-coth.h" + +typedef struct V9fsThReadlinkState { + V9fsState *s; + V9fsString *path; + V9fsString *buf; + ssize_t len; + int err; + V9fsRequest request; +} V9fsThReadlinkState; + +static void v9fs_th_do_readlink(V9fsRequest *request) +{ + V9fsThReadlinkState *vsp = container_of(request, V9fsThReadlinkState, + request); + vsp->buf->data = qemu_malloc(PATH_MAX); + + vsp->len = vsp->s->ops->readlink(&vsp->s->ctx, vsp->path->data, + vsp->buf->data, PATH_MAX - 1); + if (vsp->len > -1) { + vsp->buf->size = vsp->len; + vsp->buf->data[vsp->len] = 0; + vsp->err = 0; + } else { + vsp->err = -errno; + } +} + +int v9fs_co_readlink(V9fsState *s, V9fsString *path, V9fsString *buf, + ssize_t *len) +{ + V9fsThReadlinkState vs; + vs.s = s; + vs.path = path; + vs.buf = buf; + vs.request.func = v9fs_th_do_readlink; + vs.request.coroutine = qemu_coroutine_self(); + v9fs_qemu_submit_request(&vs.request); + qemu_coroutine_yield(); + buf->size = vs.buf->size; + buf->data = vs.buf->data; + return vs.err; +} diff --git a/hw/9pfs/virtio-9p-coth.h b/hw/9pfs/virtio-9p-coth.h index 2ec1401..d0b856e 100644 --- a/hw/9pfs/virtio-9p-coth.h +++ b/hw/9pfs/virtio-9p-coth.h @@ -48,5 +48,6 @@ extern void v9fs_thread_routine(gpointer data, gpointer user_data); extern void v9fs_qemu_process_req_done(void *arg); extern void v9fs_qemu_submit_request(V9fsRequest *req); - +extern int v9fs_co_readlink(V9fsState *, V9fsString *, + V9fsString *, ssize_t *); #endif diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index a748c34..7ef6ad8 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@ -82,23 +82,6 @@ static int v9fs_do_lstat(V9fsState *s, V9fsString *path, struct stat *stbuf) return s->ops->lstat(&s->ctx, path->data, stbuf); } -static int v9fs_do_readlink(V9fsState *s, V9fsString *path, V9fsString *buf, - ssize_t *len) -{ - int err; - buf->data = qemu_malloc(1024); - - *len = s->ops->readlink(&s->ctx, path->data, buf->data, 1024 - 1); - if (*len > -1) { - buf->size = *len; - buf->data[*len] = 0; - err = 0; - } else { - err = -errno; - } - return err; -} - static int v9fs_do_close(V9fsState *s, int fd) { return s->ops->close(&s->ctx, fd); @@ -1058,7 +1041,7 @@ static int stat_to_v9stat(V9fsState *s, V9fsString *name, if (v9stat->mode & P9_STAT_MODE_SYMLINK) { ssize_t symlink_len; - err = v9fs_do_readlink(s, name, &v9stat->extension, &symlink_len); + err = v9fs_co_readlink(s, name, &v9stat->extension, &symlink_len); if (err < 0) { return err; } @@ -3655,10 +3638,11 @@ static void v9fs_readlink(void *opaque) } v9fs_string_init(&target); - err = v9fs_do_readlink(copdu->s, &fidp->path, &target, &symlink_len); + err = v9fs_co_readlink(copdu->s, &fidp->path, &target, &symlink_len); if (err < 0) { goto out; } + offset += pdu_marshal(copdu->pdu, offset, "s", &target); err = offset; v9fs_string_free(&target);