From patchwork Sat Sep 11 06:46:24 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 64487 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 24884B70A6 for ; Sat, 11 Sep 2010 16:48:55 +1000 (EST) Received: from localhost ([127.0.0.1]:50157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OuJtM-00062q-0W for incoming@patchwork.ozlabs.org; Sat, 11 Sep 2010 02:48:52 -0400 Received: from [140.186.70.92] (port=45323 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OuJrD-0005Q1-KS for qemu-devel@nongnu.org; Sat, 11 Sep 2010 02:46:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OuJrB-0003IA-BH for qemu-devel@nongnu.org; Sat, 11 Sep 2010 02:46:39 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:58875) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OuJrB-0003HI-0u for qemu-devel@nongnu.org; Sat, 11 Sep 2010 02:46:37 -0400 Received: from flocke.weilnetz.de (p5086FB51.dip.t-dialin.net [80.134.251.81]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0MPqmw-1OyBk60Wu2-0057nt; Sat, 11 Sep 2010 08:46:28 +0200 Received: from stefan by flocke.weilnetz.de with local (Exim 4.72) (envelope-from ) id 1OuJr0-0005ST-W0; Sat, 11 Sep 2010 08:46:27 +0200 From: Stefan Weil To: QEMU Developers Date: Sat, 11 Sep 2010 08:46:24 +0200 Message-Id: <1284187585-20953-1-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.7.1 X-Provags-ID: V02:K0:o/xrRzv/2ZQor4DhY5/HkeCUW6J1f51nKYkcvyUl51v b3FKpJt8rhO4O/FnsRo4SEFHK/uUKCHXoxfRcFDqlaL1ULClqW 7czcqcMmkOyZojC5CJwEgE30H2+w3habmUgiqRaRF38wP2A0t3 RNzE2bDuDu1e+gmKek9dWsQRef1CvXKyN+WQLC+cF3Wn54WL5/ KF20GHXPS6CWcCjIQBXCJ0hPE1BAPlUTZZRF7k9J4wVz5GHReV X5tMCae8zhG3g X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Aurelien Jarno Subject: [Qemu-devel] [PATCH] mips_fulong2e: Detect format errors for function prom_set X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Add the necessary gcc attribute and fix the detected errors. Cc: Aurelien Jarno Signed-off-by: Stefan Weil --- hw/mips_fulong2e.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/mips_fulong2e.c b/hw/mips_fulong2e.c index cbe7156..2ef5070 100644 --- a/hw/mips_fulong2e.c +++ b/hw/mips_fulong2e.c @@ -77,6 +77,8 @@ static struct _loaderparams { } loaderparams; static void prom_set(uint32_t* prom_buf, int index, const char *string, ...) + __attribute__ ((format (gnu_printf, 3, 4))); +static void prom_set(uint32_t* prom_buf, int index, const char *string, ...) { va_list ap; int32_t table_addr; @@ -141,13 +143,13 @@ static int64_t load_kernel (CPUState *env) prom_size = ENVP_NB_ENTRIES * (sizeof(int32_t) + ENVP_ENTRY_SIZE); prom_buf = qemu_malloc(prom_size); - prom_set(prom_buf, index++, loaderparams.kernel_filename); + prom_set(prom_buf, index++, "%s", loaderparams.kernel_filename); if (initrd_size > 0) { - prom_set(prom_buf, index++, "rd_start=0x" PRIx64 " rd_size=%li %s", + prom_set(prom_buf, index++, "rd_start=0x%" PRIx64 " rd_size=%li %s", cpu_mips_phys_to_kseg0(NULL, initrd_offset), initrd_size, loaderparams.kernel_cmdline); } else { - prom_set(prom_buf, index++, loaderparams.kernel_cmdline); + prom_set(prom_buf, index++, "%s", loaderparams.kernel_cmdline); } /* Setup minimum environment variables */