| Message ID | 1279556597-6885-1-git-send-email-weil@mail.berlios.de |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Jul 19, 2010 at 06:23:17PM +0200, Stefan Weil wrote: > Both values are only used in exec.c, so there is no need > to make them globally available. > > Signed-off-by: Stefan Weil <weil@mail.berlios.de> > --- > exec-all.h | 2 -- > exec.c | 4 ++-- > 2 files changed, 2 insertions(+), 4 deletions(-) Thanks, applied. > diff --git a/exec-all.h b/exec-all.h > index a775582..58b5575 100644 > --- a/exec-all.h > +++ b/exec-all.h > @@ -191,8 +191,6 @@ void tb_link_page(TranslationBlock *tb, > void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr); > > extern TranslationBlock *tb_phys_hash[CODE_GEN_PHYS_HASH_SIZE]; > -extern uint8_t *code_gen_ptr; > -extern int code_gen_max_blocks; > > #if defined(USE_DIRECT_JUMP) > > diff --git a/exec.c b/exec.c > index 4641b3e..868cd7f 100644 > --- a/exec.c > +++ b/exec.c > @@ -80,7 +80,7 @@ > #define SMC_BITMAP_USE_THRESHOLD 10 > > static TranslationBlock *tbs; > -int code_gen_max_blocks; > +static int code_gen_max_blocks; > TranslationBlock *tb_phys_hash[CODE_GEN_PHYS_HASH_SIZE]; > static int nb_tbs; > /* any access to the tbs or the page table must use this lock */ > @@ -107,7 +107,7 @@ static uint8_t *code_gen_buffer; > static unsigned long code_gen_buffer_size; > /* threshold to flush the translated code buffer */ > static unsigned long code_gen_buffer_max_size; > -uint8_t *code_gen_ptr; > +static uint8_t *code_gen_ptr; > > #if !defined(CONFIG_USER_ONLY) > int phys_ram_fd; > -- > 1.7.1 > > >
diff --git a/exec-all.h b/exec-all.h index a775582..58b5575 100644 --- a/exec-all.h +++ b/exec-all.h @@ -191,8 +191,6 @@ void tb_link_page(TranslationBlock *tb, void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr); extern TranslationBlock *tb_phys_hash[CODE_GEN_PHYS_HASH_SIZE]; -extern uint8_t *code_gen_ptr; -extern int code_gen_max_blocks; #if defined(USE_DIRECT_JUMP) diff --git a/exec.c b/exec.c index 4641b3e..868cd7f 100644 --- a/exec.c +++ b/exec.c @@ -80,7 +80,7 @@ #define SMC_BITMAP_USE_THRESHOLD 10 static TranslationBlock *tbs; -int code_gen_max_blocks; +static int code_gen_max_blocks; TranslationBlock *tb_phys_hash[CODE_GEN_PHYS_HASH_SIZE]; static int nb_tbs; /* any access to the tbs or the page table must use this lock */ @@ -107,7 +107,7 @@ static uint8_t *code_gen_buffer; static unsigned long code_gen_buffer_size; /* threshold to flush the translated code buffer */ static unsigned long code_gen_buffer_max_size; -uint8_t *code_gen_ptr; +static uint8_t *code_gen_ptr; #if !defined(CONFIG_USER_ONLY) int phys_ram_fd;
Both values are only used in exec.c, so there is no need to make them globally available. Signed-off-by: Stefan Weil <weil@mail.berlios.de> --- exec-all.h | 2 -- exec.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-)