From patchwork Tue Jun 15 17:53:40 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: MORITA Kazutaka X-Patchwork-Id: 55768 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AA2E5B7DBD for ; Wed, 16 Jun 2010 04:01:46 +1000 (EST) Received: from localhost ([127.0.0.1]:43469 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOaSF-0007uQ-LN for incoming@patchwork.ozlabs.org; Tue, 15 Jun 2010 14:01:43 -0400 Received: from [140.186.70.92] (port=45533 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOaQE-0007r2-Em for qemu-devel@nongnu.org; Tue, 15 Jun 2010 13:59:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOaQC-0007q4-D6 for qemu-devel@nongnu.org; Tue, 15 Jun 2010 13:59:38 -0400 Received: from sh.osrg.net ([192.16.179.4]:48893) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOaQB-0007ok-RV for qemu-devel@nongnu.org; Tue, 15 Jun 2010 13:59:36 -0400 Received: from fs.osrg.net (postfix@fs.osrg.net [10.0.0.12]) by sh.osrg.net (8.14.3/8.14.3/OSRG-NET) with ESMTP id o5FHxUiX000895; Wed, 16 Jun 2010 02:59:30 +0900 Received: from localhost (dfs1401.osrg.net [10.68.14.1]) by fs.osrg.net (Postfix) with ESMTP id 1FEC63E02F5; Wed, 16 Jun 2010 02:59:30 +0900 (JST) From: MORITA Kazutaka To: kwolf@redhat.com Date: Wed, 16 Jun 2010 02:53:40 +0900 Message-Id: <1276624421-23999-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: <1276624421-23999-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> References: <1276624421-23999-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> X-Dispatcher: imput version 20070423(IM149) Lines: 26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (sh.osrg.net [192.16.179.4]); Wed, 16 Jun 2010 02:59:31 +0900 (JST) X-Virus-Scanned: clamav-milter 0.96.1 at sh X-Virus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: qemu-devel@nongnu.org, morita.kazutaka@lab.ntt.co.jp Subject: [Qemu-devel] [PATCH 1/2] qemu-io: retry fgets() when errno is EINTR X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org posix-aio-compat sends a signal in aio operations, so we should consider that fgets() could be interrupted here. Signed-off-by: MORITA Kazutaka --- cmd.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/cmd.c b/cmd.c index 2336334..460df92 100644 --- a/cmd.c +++ b/cmd.c @@ -272,7 +272,10 @@ fetchline(void) return NULL; printf("%s", get_prompt()); fflush(stdout); +again: if (!fgets(line, MAXREADLINESZ, stdin)) { + if (errno == EINTR) + goto again; free(line); return NULL; }