From patchwork Mon Jan 18 12:11:28 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 43070 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 045D7B7C8E for ; Mon, 18 Jan 2010 23:34:35 +1100 (EST) Received: from localhost ([127.0.0.1]:52342 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWqXp-0007Tg-Hj for incoming@patchwork.ozlabs.org; Mon, 18 Jan 2010 07:17:21 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NWqTK-0006hp-4x for qemu-devel@nongnu.org; Mon, 18 Jan 2010 07:12:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NWqTE-0006gU-J6 for qemu-devel@nongnu.org; Mon, 18 Jan 2010 07:12:41 -0500 Received: from [199.232.76.173] (port=51036 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWqTE-0006gR-BV for qemu-devel@nongnu.org; Mon, 18 Jan 2010 07:12:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26029) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NWqTE-0001bE-1b for qemu-devel@nongnu.org; Mon, 18 Jan 2010 07:12:36 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0ICCZXx020583 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 18 Jan 2010 07:12:35 -0500 Received: from localhost.localdomain (dhcp-5-175.str.redhat.com [10.32.5.175]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0ICCV9o011108; Mon, 18 Jan 2010 07:12:34 -0500 From: Kevin Wolf To: qemu-devel@nongnu.org Date: Mon, 18 Jan 2010 13:11:28 +0100 Message-Id: <1263816696-24122-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1263816696-24122-1-git-send-email-kwolf@redhat.com> References: <1263816696-24122-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Kevin Wolf Subject: [Qemu-devel] [PATCH 02/10] qcow2: Fix error handling in qcow_save_vmstate X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Don't assume success but pass the bdrv_pwrite return value on. Signed-off-by: Kevin Wolf Reviewed-by: Christoph Hellwig --- block/qcow2.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 6622eba..e06f4dd 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1163,12 +1163,13 @@ static int qcow_save_vmstate(BlockDriverState *bs, const uint8_t *buf, { BDRVQcowState *s = bs->opaque; int growable = bs->growable; + int ret; bs->growable = 1; - bdrv_pwrite(bs, qcow_vm_state_offset(s) + pos, buf, size); + ret = bdrv_pwrite(bs, qcow_vm_state_offset(s) + pos, buf, size); bs->growable = growable; - return size; + return ret; } static int qcow_load_vmstate(BlockDriverState *bs, uint8_t *buf,