From patchwork Wed Jan 6 22:47:10 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 42358 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 841DFB6EF2 for ; Thu, 7 Jan 2010 10:02:23 +1100 (EST) Received: from localhost ([127.0.0.1]:52665 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSetQ-0007L2-U7 for incoming@patchwork.ozlabs.org; Wed, 06 Jan 2010 18:02:20 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NSeg2-0008Cr-KQ for qemu-devel@nongnu.org; Wed, 06 Jan 2010 17:48:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NSefx-00085Y-CC for qemu-devel@nongnu.org; Wed, 06 Jan 2010 17:48:29 -0500 Received: from [199.232.76.173] (port=50129 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSefw-00085F-QW for qemu-devel@nongnu.org; Wed, 06 Jan 2010 17:48:24 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:50561) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NSefw-0005Jk-Bb for qemu-devel@nongnu.org; Wed, 06 Jan 2010 17:48:24 -0500 Received: from smtp05.web.de (fmsmtp05.dlan.cinetic.de [172.20.4.166]) by fmmailgate03.web.de (Postfix) with ESMTP id 96BB513B9ECD8; Wed, 6 Jan 2010 23:47:25 +0100 (CET) Received: from [84.148.52.231] (helo=localhost.localdomain) by smtp05.web.de with asmtp (WEB.DE 4.110 #314) id 1NSeey-0001R8-00; Wed, 06 Jan 2010 23:47:24 +0100 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= To: qemu-devel@nongnu.org Date: Wed, 6 Jan 2010 23:47:10 +0100 Message-Id: <1262818037-926-5-git-send-email-andreas.faerber@web.de> X-Mailer: git-send-email 1.6.5.3 In-Reply-To: <1262818037-926-4-git-send-email-andreas.faerber@web.de> References: <1262818037-926-1-git-send-email-andreas.faerber@web.de> <1262818037-926-2-git-send-email-andreas.faerber@web.de> <1262818037-926-3-git-send-email-andreas.faerber@web.de> <1262818037-926-4-git-send-email-andreas.faerber@web.de> MIME-Version: 1.0 X-Sender: Andreas.Faerber@web.de X-Provags-ID: V01U2FsdGVkX194pspENd+HHH6kPUGOg9/fNbG5DHkAYnZwMstb ytRv3BoCly2V7uLiGv7o+QVQ13pogHp7rCP5bu7N/gwAMw2dEC FthCo+c+Smuf1srvtvDg== X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 Cc: John Arbuckle , =?UTF-8?q?Andreas=20F=C3=A4rber?= Subject: [Qemu-devel] [PATCH v2 RESEND 04/11] Cocoa: Silence type warning X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Add const for "qemu" character literal, to avoid: warning: initialization discards qualifiers from pointer target type An earlier patch by John proposed to use char[5]. Since we do not modify the text and later copy it into malloc'ed memory, marking it as const seems sufficient. Signed-off-by: Andreas Färber Cc: John Arbuckle --- cocoa.m | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cocoa.m b/cocoa.m index f8c2e00..0a95c77 100644 --- a/cocoa.m +++ b/cocoa.m @@ -791,7 +791,7 @@ static int cocoa_keycode_to_qemu(int keycode) if(returnCode == NSCancelButton) { exit(0); } else if(returnCode == NSOKButton) { - char *bin = "qemu"; + const char *bin = "qemu"; char *img = (char*)[ [ sheet filename ] cStringUsingEncoding:NSASCIIStringEncoding]; char **argv = (char**)malloc( sizeof(char*)*3 );