From patchwork Thu Dec 10 19:15:55 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 40873 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4E6EFB6EE9 for ; Fri, 11 Dec 2009 06:30:04 +1100 (EST) Received: from localhost ([127.0.0.1]:47305 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIoi8-00048J-TF for incoming@patchwork.ozlabs.org; Thu, 10 Dec 2009 14:30:00 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NIoV9-0006ZD-No for qemu-devel@nongnu.org; Thu, 10 Dec 2009 14:16:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NIoV6-0006T7-DB for qemu-devel@nongnu.org; Thu, 10 Dec 2009 14:16:35 -0500 Received: from [199.232.76.173] (port=56463 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIoV5-0006Su-HB for qemu-devel@nongnu.org; Thu, 10 Dec 2009 14:16:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40555) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NIoV5-0001Bv-73 for qemu-devel@nongnu.org; Thu, 10 Dec 2009 14:16:31 -0500 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBAJGUdT010626 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 Dec 2009 14:16:30 -0500 Received: from localhost (vpn-9-38.rdu.redhat.com [10.11.9.38]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBAJGSAs027746; Thu, 10 Dec 2009 14:16:30 -0500 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Thu, 10 Dec 2009 17:15:55 -0200 Message-Id: <1260472570-13973-6-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1260472570-13973-1-git-send-email-lcapitulino@redhat.com> References: <1260472570-13973-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: aliguori@us.ibm.com Subject: [Qemu-devel] [PATCH 05/20] monitor: Fix do_info_balloon() output X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Monitor commands should always return values in bytes and info commands should always return a QDict. Signed-off-by: Luiz Capitulino --- monitor.c | 19 ++++++++++++++++--- 1 files changed, 16 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index a38a103..aa56ec7 100644 --- a/monitor.c +++ b/monitor.c @@ -1919,12 +1919,24 @@ static void do_balloon(Monitor *mon, const QDict *qdict, QObject **ret_data) static void monitor_print_balloon(Monitor *mon, const QObject *data) { - monitor_printf(mon, "balloon: actual=%d\n", - (int)qint_get_int(qobject_to_qint(data))); + QDict *qdict; + + qdict = qobject_to_qdict(data); + + monitor_printf(mon, "balloon: actual=%" PRId64 "\n", + qdict_get_int(qdict, "balloon") >> 20); } /** * do_info_balloon(): Balloon information + * + * Return a QDict with the following information: + * + * - "balloon": current balloon value in bytes + * + * Example: + * + * { "balloon": 1073741824 } */ static void do_info_balloon(Monitor *mon, QObject **ret_data) { @@ -1936,7 +1948,8 @@ static void do_info_balloon(Monitor *mon, QObject **ret_data) else if (actual == 0) qemu_error_new(QERR_DEVICE_NOT_ACTIVE, "balloon"); else - *ret_data = QOBJECT(qint_from_int((int)(actual >> 20))); + *ret_data = qobject_from_jsonf("{ 'balloon': %" PRId64 "}", + (int64_t) actual); } static qemu_acl *find_acl(Monitor *mon, const char *name)