From patchwork Wed Dec 2 13:46:10 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Glauber Costa X-Patchwork-Id: 40063 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 84714B7BE3 for ; Thu, 3 Dec 2009 03:21:12 +1100 (EST) Received: from localhost ([127.0.0.1]:34147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFrwy-0006wI-QS for incoming@patchwork.ozlabs.org; Wed, 02 Dec 2009 11:21:08 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFpXM-0004aw-Pp for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:46:33 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFpXF-0004SH-Sp for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:46:30 -0500 Received: from [199.232.76.173] (port=58096 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFpXF-0004Rk-Kc for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:46:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22630) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFpXE-00041q-Q8 for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:46:25 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB2DkNQl008511 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Dec 2009 08:46:23 -0500 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nB2DkGtX025779; Wed, 2 Dec 2009 08:46:22 -0500 From: Glauber Costa To: qemu-devel@nongnu.org Date: Wed, 2 Dec 2009 11:46:10 -0200 Message-Id: <1259761575-3953-5-git-send-email-glommer@redhat.com> In-Reply-To: <1259761575-3953-4-git-send-email-glommer@redhat.com> References: <1259761575-3953-1-git-send-email-glommer@redhat.com> <1259761575-3953-2-git-send-email-glommer@redhat.com> <1259761575-3953-3-git-send-email-glommer@redhat.com> <1259761575-3953-4-git-send-email-glommer@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: aliguori@us.ibm.com, avi@redhat.com Subject: [Qemu-devel] [PATCH 4/9] provide i8259-kvm X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch provides the file i8259-kvm.c, which implements a schim over the kvm in-kernel PIC. Signed-off-by: Glauber Costa --- Makefile.target | 2 +- hw/i8259-kvm.c | 112 +++++++++++++++++++++++++++++++++++++++++++++++++++++ hw/pc.c | 8 +++- hw/pc.h | 1 + kvm-all.c | 7 ++- kvm.h | 4 ++ target-i386/kvm.c | 26 ++++++++++++ target-ppc/kvm.c | 5 ++ 8 files changed, 161 insertions(+), 4 deletions(-) create mode 100644 hw/i8259-kvm.c diff --git a/Makefile.target b/Makefile.target index 844ba46..8fb68a4 100644 --- a/Makefile.target +++ b/Makefile.target @@ -199,7 +199,7 @@ obj-i386-y += usb-uhci.o vmmouse.o vmport.o vmware_vga.o hpet.o obj-i386-y += device-hotplug.o pci-hotplug.o smbios.o wdt_ib700.o obj-i386-y += ne2000-isa.o -obj-i386-$(CONFIG_KVM) += ioapic-kvm.o +obj-i386-$(CONFIG_KVM) += ioapic-kvm.o i8259-kvm.o # shared objects obj-ppc-y = ppc.o ide/core.o ide/qdev.o ide/isa.o ide/pci.o ide/macio.o diff --git a/hw/i8259-kvm.c b/hw/i8259-kvm.c new file mode 100644 index 0000000..bd6387b --- /dev/null +++ b/hw/i8259-kvm.c @@ -0,0 +1,112 @@ +#include "hw.h" +#include "pc.h" +#include "isa.h" +#include "monitor.h" +#include "qemu-timer.h" +#include "kvm.h" + +static void kvm_i8259_set_irq(void *opaque, int irq, int level) +{ + int pic_ret; + + if (kvm_set_irq(irq, level, &pic_ret)) { + if (pic_ret != 0) + /* In theory, we should not be using any apic state, but we need + * to warn devices such as the rtc about state of delivery. Since this + * one is just a marker, it is no big deal */ + apic_set_irq_delivered(); + return; + } +} + +static void kvm_pic_reset(void *opaque) +{ + struct kvm_pic_state *s = opaque; + struct kvm_irqchip *chip; + + s->last_irr = 0; + s->irr = 0; + s->imr = 0; + s->isr = 0; + s->priority_add = 0; + s->irq_base = 0; + s->read_reg_select = 0; + s->poll = 0; + s->special_mask = 0; + s->init_state = 0; + s->auto_eoi = 0; + s->rotate_on_auto_eoi = 0; + s->special_fully_nested_mode = 0; + s->init4 = 0; + + chip = container_of(s, struct kvm_irqchip, chip.pic); + kvm_set_irqchip(chip); +} + +static void pic_pre_save(void *opaque) +{ + struct kvm_pic_state *s = opaque; + struct kvm_irqchip *chip; + + chip = container_of(s, struct kvm_irqchip, chip.pic); + + kvm_get_irqchip(chip); +} + +static int pic_post_load(void *opaque, int version_id) +{ + struct kvm_pic_state *s = opaque; + struct kvm_irqchip *chip; + + chip = container_of(s, struct kvm_irqchip, chip.pic); + + return kvm_set_irqchip(chip); +} + +static const VMStateDescription vmstate_kvm_pic = { + .name = "i8259-kvm", + .version_id = 1, + .pre_save = pic_pre_save, + .post_load = pic_post_load, + .minimum_version_id = 1, + .fields = (VMStateField []) { + VMSTATE_UINT8(last_irr, struct kvm_pic_state), + VMSTATE_UINT8(irr, struct kvm_pic_state), + VMSTATE_UINT8(imr, struct kvm_pic_state), + VMSTATE_UINT8(isr, struct kvm_pic_state), + VMSTATE_UINT8(priority_add, struct kvm_pic_state), + VMSTATE_UINT8(irq_base, struct kvm_pic_state), + VMSTATE_UINT8(read_reg_select, struct kvm_pic_state), + VMSTATE_UINT8(poll, struct kvm_pic_state), + VMSTATE_UINT8(special_mask, struct kvm_pic_state), + VMSTATE_UINT8(init_state, struct kvm_pic_state), + VMSTATE_UINT8(auto_eoi, struct kvm_pic_state), + VMSTATE_UINT8(rotate_on_auto_eoi, struct kvm_pic_state), + VMSTATE_UINT8(special_fully_nested_mode, struct kvm_pic_state), + VMSTATE_UINT8(init4, struct kvm_pic_state), + VMSTATE_UINT8(elcr, struct kvm_pic_state), + VMSTATE_END_OF_LIST() + } +}; + +static void kvm_pic_init1(int io_addr, struct kvm_pic_state *s) +{ + vmstate_register(io_addr, &vmstate_kvm_pic, s); + qemu_register_reset(kvm_pic_reset, s); +} + +qemu_irq *kvm_i8259_init(qemu_irq parent_irq) +{ + struct kvm_irqchip *master, *slave; + + master = qemu_mallocz(sizeof(*master)); + slave = qemu_mallocz(sizeof(*slave)); + + master->chip_id = KVM_IRQCHIP_PIC_MASTER; + slave->chip_id = KVM_IRQCHIP_PIC_SLAVE; + + kvm_pic_init1(0x20, &master->chip.pic); + kvm_pic_init1(0xa0, &slave->chip.pic); + + return qemu_allocate_irqs(kvm_i8259_set_irq, master, 16); +} diff --git a/hw/pc.c b/hw/pc.c index 7bff913..a58562a 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -1098,8 +1098,14 @@ static void pc_init1(ram_addr_t ram_size, } cpu_irq = qemu_allocate_irqs(pic_irq_request, NULL, 1); - i8259 = i8259_init(cpu_irq[0]); isa_irq_state = qemu_mallocz(sizeof(*isa_irq_state)); + + if (kvm_enabled() && kvm_irqchip_in_kernel()) { + i8259 = kvm_i8259_init(cpu_irq[0]); + } else { + i8259 = i8259_init(cpu_irq[0]); + } + isa_irq_state->i8259 = i8259; isa_irq = qemu_allocate_irqs(isa_irq_handler, isa_irq_state, 24); diff --git a/hw/pc.h b/hw/pc.h index 4c9b4c3..3d79b9d 100644 --- a/hw/pc.h +++ b/hw/pc.h @@ -34,6 +34,7 @@ uint32_t pic_intack_read(PicState2 *s); void pic_info(Monitor *mon); void irq_info(Monitor *mon); +qemu_irq *kvm_i8259_init(qemu_irq parent_irq); /* APIC */ typedef struct IOAPICState IOAPICState; void apic_deliver_irq(uint8_t dest, uint8_t dest_mode, diff --git a/kvm-all.c b/kvm-all.c index 35230c1..e46093f 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -393,7 +393,6 @@ int kvm_check_extension(KVMState *s, unsigned int extension) return ret; } -#ifdef KVM_CAP_IRQCHIP int kvm_set_irqchip(struct kvm_irqchip *chip) { if (!kvm_state->irqchip_in_kernel) { @@ -411,7 +410,11 @@ int kvm_get_irqchip(struct kvm_irqchip *chip) return kvm_vm_ioctl(kvm_state, KVM_GET_IRQCHIP, chip); } -#endif + +int kvm_set_irq(int irq, int level, int *status) +{ + return kvm_arch_set_irq(kvm_state, irq, level, status); +} int kvm_init(int smp_cpus) { diff --git a/kvm.h b/kvm.h index 70839c2..3b358d0 100644 --- a/kvm.h +++ b/kvm.h @@ -67,6 +67,8 @@ int kvm_irqchip_in_kernel(void); int kvm_set_irqchip(struct kvm_irqchip *chip); int kvm_get_irqchip(struct kvm_irqchip *chip); +int kvm_set_irq(int irq, int level, int *status); + /* internal API */ struct KVMState; @@ -96,6 +98,8 @@ int kvm_arch_init_vcpu(CPUState *env); void kvm_arch_reset_vcpu(CPUState *env); +int kvm_arch_set_irq(KVMState *s, int irq, int level, int *status); + struct kvm_guest_debug; struct kvm_debug_exit_arch; diff --git a/target-i386/kvm.c b/target-i386/kvm.c index d6bc23a..cf42f85 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -992,3 +992,29 @@ void kvm_arch_update_guest_debug(CPUState *env, struct kvm_guest_debug *dbg) } } #endif /* KVM_CAP_SET_GUEST_DEBUG */ + +int kvm_arch_set_irq(KVMState *s, int irq, int level, int *status) +{ + struct kvm_irq_level event; + int r; + + if (!kvm_irqchip_in_kernel()) { + return 0; + } + + event.level = level; + event.irq = irq; + + r = kvm_vm_ioctl(s, KVM_IRQ_LINE_STATUS, &event); + + if (r < 0) + return 0; + + if (status) { + *status = event.status; + } + + return 1; +} + + diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index 4e1c65f..d08639b 100644 --- a/target-ppc/kvm.c +++ b/target-ppc/kvm.c @@ -57,6 +57,11 @@ void kvm_arch_reset_vcpu(CPUState *env) { } +int kvm_arch_set_irq(KVMState *s, int irq, int level, int *status) +{ + return -ENOSYS; +} + int kvm_arch_put_registers(CPUState *env) { struct kvm_regs regs;