From patchwork Fri Nov 27 11:06:02 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 39622 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C2E771007D2 for ; Fri, 27 Nov 2009 22:07:11 +1100 (EST) Received: from localhost ([127.0.0.1]:58380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NDyfH-0005H1-Uk for incoming@patchwork.ozlabs.org; Fri, 27 Nov 2009 06:07:04 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NDyeY-0005Gj-Es for qemu-devel@nongnu.org; Fri, 27 Nov 2009 06:06:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NDyeS-0005Cg-If for qemu-devel@nongnu.org; Fri, 27 Nov 2009 06:06:16 -0500 Received: from [199.232.76.173] (port=39530 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NDyeS-0005CT-CD for qemu-devel@nongnu.org; Fri, 27 Nov 2009 06:06:12 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:57871) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NDyeR-0006da-MD for qemu-devel@nongnu.org; Fri, 27 Nov 2009 06:06:12 -0500 Received: from flocke.weilnetz.de (p54ADC6AE.dip.t-dialin.net [84.173.198.174]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0LsftZ-1OB0Lh1I2j-012oDE; Fri, 27 Nov 2009 12:06:08 +0100 Received: from stefan by flocke.weilnetz.de with local (Exim 4.69) (envelope-from ) id 1NDyeN-0002mt-Fx; Fri, 27 Nov 2009 12:06:07 +0100 From: Stefan Weil To: QEMU Developers Date: Fri, 27 Nov 2009 12:06:02 +0100 Message-Id: <1259319962-10683-1-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.6.5 X-Provags-ID: V01U2FsdGVkX1+Fiwida8iu9to8bMcDOtntTmJdqn2XBErBl+f C7RCft0DFykqfzAMEMFHNIQqvQnHsqUV1Hlwt0sB4hul6QNgF+ toczjrFgT6iCxPP1/AkO+yRt9mzelv2qGGffPnbpRpEHsrhtar TaA== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Subject: [Qemu-devel] [PATCH] eepro100: Improve debug messages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org * buf was too small for longer register names. * Use consistent upper case for nouns in register names. * Use better name for array with e100 register names. Signed-off-by: Stefan Weil --- hw/eepro100.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 8734907..4210d8a 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -635,22 +635,22 @@ static void nic_reset(void *opaque) } #if defined(DEBUG_EEPRO100) -static const char * const reg[PCI_IO_SIZE / 4] = { +static const char * const e100_reg[PCI_IO_SIZE / 4] = { "Command/Status", "General Pointer", "Port", "EEPROM/Flash Control", "MDI Control", "Receive DMA Byte Count", - "Flow control", + "Flow Control", "General Status/Control" }; static char *regname(uint32_t addr) { - static char buf[16]; + static char buf[32]; if (addr < PCI_IO_SIZE) { - const char *r = reg[addr / 4]; + const char *r = e100_reg[addr / 4]; if (r != 0) { snprintf(buf, sizeof(buf), "%s+%u", r, addr % 4); } else {