From patchwork Tue Nov 17 10:17:41 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 38612 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CCA99B70CF for ; Tue, 17 Nov 2009 21:35:55 +1100 (EST) Received: from localhost ([127.0.0.1]:33928 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NALPc-0005WQ-Pg for incoming@patchwork.ozlabs.org; Tue, 17 Nov 2009 05:35:52 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAL8c-0000Kq-9W for qemu-devel@nongnu.org; Tue, 17 Nov 2009 05:18:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAL8T-0000FZ-3C for qemu-devel@nongnu.org; Tue, 17 Nov 2009 05:18:13 -0500 Received: from [199.232.76.173] (port=58251 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAL8S-0000FB-DW for qemu-devel@nongnu.org; Tue, 17 Nov 2009 05:18:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11611) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NAL8R-0006wa-Ra for qemu-devel@nongnu.org; Tue, 17 Nov 2009 05:18:08 -0500 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAHAI7CV010082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Nov 2009 05:18:07 -0500 Received: from zweiblum.home.kraxel.org (vpn1-7-195.ams2.redhat.com [10.36.7.195]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id nAHAI0lv025186; Tue, 17 Nov 2009 05:18:02 -0500 Received: by zweiblum.home.kraxel.org (Postfix, from userid 500) id 2578F70061; Tue, 17 Nov 2009 11:17:52 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Tue, 17 Nov 2009 11:17:41 +0100 Message-Id: <1258453071-3496-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1258453071-3496-1-git-send-email-kraxel@redhat.com> References: <1258453071-3496-1-git-send-email-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Gerd Hoffmann Subject: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Gerd Hoffmann Reviewed-by: Christoph Hellwig --- hw/scsi-bus.c | 1 + hw/scsi-generic.c | 17 ++++++----------- hw/scsi.h | 6 ++++++ 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index c74d085..73cfe58 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -119,4 +119,5 @@ void scsi_req_init(SCSIRequest *req, SCSIDevice *d, uint32_t tag, uint32_t lun) req->tag = tag; req->lun = lun; req->aiocb = NULL; + memset(&req->cmd, 0, sizeof(req->cmd)); } diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index 1e1907e..68518da 100644 --- a/hw/scsi-generic.c +++ b/hw/scsi-generic.c @@ -42,7 +42,6 @@ do { fprintf(stderr, "scsi-generic: " fmt , ## __VA_ARGS__); } while (0) #define SET_CD_SPEED 0xbb #define BLANK 0xa1 -#define SCSI_CMD_BUF_SIZE 16 #define SCSI_SENSE_BUF_SIZE 96 #define SG_ERR_DRIVER_TIMEOUT 0x06 @@ -56,8 +55,6 @@ typedef struct SCSIGenericState SCSIGenericState; typedef struct SCSIGenericReq { SCSIRequest req; - uint8_t cmd[SCSI_CMD_BUF_SIZE]; - int cmdlen; uint8_t *buf; int buflen; int len; @@ -92,9 +89,7 @@ static SCSIGenericReq *scsi_new_request(SCSIDevice *d, uint32_t tag, uint32_t lu r->buflen = 0; } scsi_req_init(&r->req, d, tag, lun); - memset(r->cmd, 0, sizeof(r->cmd)); memset(&r->io_header, 0, sizeof(r->io_header)); - r->cmdlen = 0; r->len = 0; QTAILQ_INSERT_TAIL(&d->requests, &r->req, next); @@ -177,8 +172,8 @@ static int execute_command(BlockDriverState *bdrv, r->io_header.dxfer_direction = direction; r->io_header.dxferp = r->buf; r->io_header.dxfer_len = r->buflen; - r->io_header.cmdp = r->cmd; - r->io_header.cmd_len = r->cmdlen; + r->io_header.cmdp = r->req.cmd.buf; + r->io_header.cmd_len = r->req.cmd.len; r->io_header.mx_sb_len = sizeof(s->sensebuf); r->io_header.sbp = s->sensebuf; r->io_header.timeout = MAX_UINT; @@ -234,7 +229,7 @@ static void scsi_read_data(SCSIDevice *d, uint32_t tag) return; } - if (r->cmd[0] == REQUEST_SENSE && s->driver_status & SG_ERR_DRIVER_SENSE) + if (r->req.cmd.buf[0] == REQUEST_SENSE && s->driver_status & SG_ERR_DRIVER_SENSE) { s->senselen = MIN(r->len, s->senselen); memcpy(r->buf, s->sensebuf, s->senselen); @@ -269,7 +264,7 @@ static void scsi_write_complete(void * opaque, int ret) return; } - if (r->cmd[0] == MODE_SELECT && r->cmd[4] == 12 && + if (r->req.cmd.buf[0] == MODE_SELECT && r->req.cmd.buf[4] == 12 && s->type == TYPE_TAPE) { s->blocksize = (r->buf[9] << 16) | (r->buf[10] << 8) | r->buf[11]; DPRINTF("block size %d\n", s->blocksize); @@ -533,8 +528,8 @@ static int32_t scsi_send_command(SCSIDevice *d, uint32_t tag, } r = scsi_new_request(d, tag, lun); - memcpy(r->cmd, cmd, cmdlen); - r->cmdlen = cmdlen; + memcpy(r->req.cmd.buf, cmd, cmdlen); + r->req.cmd.len = cmdlen; if (len == 0) { if (r->buf != NULL) diff --git a/hw/scsi.h b/hw/scsi.h index 85ce8a9..e3f28ea 100644 --- a/hw/scsi.h +++ b/hw/scsi.h @@ -4,6 +4,8 @@ #include "qdev.h" #include "block.h" +#define SCSI_CMD_BUF_SIZE 16 + /* scsi-disk.c */ enum scsi_reason { SCSI_REASON_DONE, /* Command complete. */ @@ -21,6 +23,10 @@ typedef struct SCSIRequest { SCSIDevice *dev; uint32_t tag; uint32_t lun; + struct { + uint8_t buf[SCSI_CMD_BUF_SIZE]; + int len; + } cmd; BlockDriverAIOCB *aiocb; QTAILQ_ENTRY(SCSIRequest) next; } SCSIRequest;