From patchwork Thu Oct 29 18:42:26 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 37219 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7C313B7BF0 for ; Fri, 30 Oct 2009 05:48:33 +1100 (EST) Received: from localhost ([127.0.0.1]:44396 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3a2v-00078b-VN for incoming@patchwork.ozlabs.org; Thu, 29 Oct 2009 14:48:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3ZxV-0004zG-Ll for qemu-devel@nongnu.org; Thu, 29 Oct 2009 14:42:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3ZxQ-0004wq-Nx for qemu-devel@nongnu.org; Thu, 29 Oct 2009 14:42:53 -0400 Received: from [199.232.76.173] (port=39769 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3ZxQ-0004wm-Ka for qemu-devel@nongnu.org; Thu, 29 Oct 2009 14:42:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10252) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3ZxQ-0008Nl-1u for qemu-devel@nongnu.org; Thu, 29 Oct 2009 14:42:48 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9TIgl7w014963; Thu, 29 Oct 2009 14:42:47 -0400 Received: from localhost (vpn-12-126.rdu.redhat.com [10.11.12.126]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9TIgjYm015866; Thu, 29 Oct 2009 14:42:46 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Thu, 29 Oct 2009 16:42:26 -0200 Message-Id: <1256841750-15228-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1256841750-15228-1-git-send-email-lcapitulino@redhat.com> References: <1256841750-15228-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: pbonzini@redhat.com, aliguori@us.ibm.com, kraxel@redhat.com, hollisb@us.ibm.com Subject: [Qemu-devel] [PATCH 3/7] monitor: QError support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This commit paves the way for QError support in the Monitor, it adds a QError member to the Monitor struct and functions to check and print it. Additionally, it introduces qemu_error_structed() which should be used by monitor handlers which report errors. This new function has to be used in place of qemu_error(), which will become private when all the conversion is done. Basically, the Monitor's error flow is something like this: 1. An error happens in the handler, it calls qemu_error_structed() 2. qemu_error_structed() builds a new QError object and stores it in the Monitor struct 3. The handler returns 4. Top level Monitor code checks the Monitor struct and calls qerror_print() to print the error When in protocol mode, step 4 will use the specified QError to build a protocol error response, intead of calling qerror_print(). Signed-off-by: Luiz Capitulino --- monitor.c | 43 ++++++++++++++++++++++++++++++++++++++++++- sysemu.h | 7 +++++++ 2 files changed, 49 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 109ff5c..4d56b8e 100644 --- a/monitor.c +++ b/monitor.c @@ -49,6 +49,7 @@ #include "qlist.h" #include "qdict.h" #include "qstring.h" +#include "qerror.h" //#define DEBUG //#define DEBUG_COMPLETION @@ -103,6 +104,7 @@ struct Monitor { CPUState *mon_cpu; BlockDriverCompletionFunc *password_completion_cb; void *password_opaque; + QError *error; QLIST_HEAD(,mon_fd_t) fds; QLIST_ENTRY(Monitor) entry; }; @@ -3146,6 +3148,18 @@ fail: return NULL; } +static inline int monitor_has_error(const Monitor *mon) +{ + return mon->error != NULL; +} + +static void monitor_print_error(Monitor *mon) +{ + qerror_print(mon->error); + QDECREF(mon->error); + mon->error = NULL; +} + static void monitor_handle_command(Monitor *mon, const char *cmdline) { QDict *qdict; @@ -3171,7 +3185,10 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) cmd->mhandler.cmd(mon, qdict); } - qemu_errors_to_previous(); + if (monitor_has_error(mon)) + monitor_print_error(mon); + + qemu_errors_to_previous(); out: QDECREF(qdict); @@ -3622,3 +3639,27 @@ void qemu_error(const char *fmt, ...) break; } } + +void qemu_error_qerror(QErrorCode code, const char *file, int linenr, + const char *fmt, ...) +{ + va_list va; + QError *qerror; + + assert(qemu_error_sink != NULL); + + va_start(va, fmt); + qerror = qerror_from_info(code, file, linenr, fmt, &va); + va_end(va); + + switch (qemu_error_sink->dest) { + case ERR_SINK_FILE: + qerror_print(qerror); + QDECREF(qerror); + break; + case ERR_SINK_MONITOR: + assert(qemu_error_sink->mon->error == NULL); + qemu_error_sink->mon->error = qerror; + break; + } +} diff --git a/sysemu.h b/sysemu.h index 17af024..440a47c 100644 --- a/sysemu.h +++ b/sysemu.h @@ -7,6 +7,7 @@ #include "qemu-queue.h" #include "qemu-timer.h" #include "qdict.h" +#include "qerror.h" #ifdef _WIN32 #include @@ -71,6 +72,12 @@ void qemu_errors_to_file(FILE *fp); void qemu_errors_to_mon(Monitor *mon); void qemu_errors_to_previous(void); void qemu_error(const char *fmt, ...) __attribute__ ((format(printf, 1, 2))); +void qemu_error_qerror(QErrorCode code, const char *file, int linenr, + const char *fmt, ...) + __attribute__ ((format(printf, 4, 5))); + +#define qemu_error_structed(code, fmt, ...) \ + qemu_error_qerror(code, __FILE__, __LINE__, fmt, ## __VA_ARGS__) #ifdef _WIN32 /* Polling handling */