Message ID | 1254485404.1738.14.camel@localhost.localdomain |
---|---|
State | Superseded |
Headers | show |
diff --git a/linux-user/linuxload.c b/linux-user/linuxload.c index 4091bdc..2d778a2 100644 --- a/linux-user/linuxload.c +++ b/linux-user/linuxload.c @@ -96,7 +96,6 @@ static int prepare_binprm(struct linux_binprm *bprm) } } - memset(bprm->buf, 0, sizeof(bprm->buf)); retval = lseek(bprm->fd, 0L, SEEK_SET); if(retval >= 0) { retval = read(bprm->fd, bprm->buf, 128);
prepare_binprm() zeroes bprm->buf. That buffer is already zeroed in main() and hasn't been touched since so that is not necessary. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Just a minor issue that I noticed while reading the code for some other reason. bsd-user/bsdload.c could need a similar patch. I haven't looked at that yet. linux-user/linuxload.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)