From patchwork Mon Aug 31 14:29:34 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 32662 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id AF577B7B75 for ; Tue, 1 Sep 2009 01:28:52 +1000 (EST) Received: from localhost ([127.0.0.1]:54526 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mi8oK-0003Sf-OI for incoming@patchwork.ozlabs.org; Mon, 31 Aug 2009 11:28:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mi7tJ-0003EY-I2 for qemu-devel@nongnu.org; Mon, 31 Aug 2009 10:29:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mi7tE-0003CL-Pt for qemu-devel@nongnu.org; Mon, 31 Aug 2009 10:29:53 -0400 Received: from [199.232.76.173] (port=38237 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mi7tE-0003CH-Mr for qemu-devel@nongnu.org; Mon, 31 Aug 2009 10:29:48 -0400 Received: from mx20.gnu.org ([199.232.41.8]:20389) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mi7tE-0006YB-Cf for qemu-devel@nongnu.org; Mon, 31 Aug 2009 10:29:48 -0400 Received: from moutng.kundenserver.de ([212.227.126.177]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mi7tB-0001FS-D7 for qemu-devel@nongnu.org; Mon, 31 Aug 2009 10:29:45 -0400 Received: from flocke.weilnetz.de (p54ADF6A0.dip.t-dialin.net [84.173.246.160]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0MKv1o-1Mi7t12mDk-000HNf; Mon, 31 Aug 2009 16:29:36 +0200 Received: from stefan by flocke.weilnetz.de with local (Exim 4.69) (envelope-from ) id 1Mi7t0-00020k-IE; Mon, 31 Aug 2009 16:29:34 +0200 From: Stefan Weil To: QEMU Developers Date: Mon, 31 Aug 2009 16:29:34 +0200 Message-Id: <1251728974-7708-1-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.5.6.5 MIME-Version: 1.0 X-Provags-ID: V01U2FsdGVkX1//TSQuPiUwmy/hK0HTMK+dRp1e4U/cD62uQke Idqdt2hNIGIgtFPuUNRb8IWJNkVsDr0n9PKu/Lq7DfAVU+GMGo y9Zv3EodQQQrC248oJ2nT25TO717AklSOSeW2dVqs04f2NJUZR yGQ== X-Detected-Operating-System: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: Subject: [Qemu-devel] [PATCH] Fix compiler warnings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Starting with commit df7a86ed735eafefbd046c8cad7134652fe3f600, mingw32 builds result in a compiler warning for dns_addr: CC slirp/slirp.o /home/stefan/src/qemu/savannah/qemu/slirp/slirp.c:50: warning: missing braces around initializer /home/stefan/src/qemu/savannah/qemu/slirp/slirp.c:50: warning: (near initialization for ‘dns_addr.S_un’) Removing the assignment fixes the warning without the need of special code for mingw32 (and also saves some bytes in the resulting binary). To fix another potential compiler warning, the missing 'static' attribute was added. The same changes were applied to dns_addr_time. Signed-off-by: Stefan Weil --- slirp/slirp.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index b5335a5..691420e 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -47,8 +47,8 @@ static int do_slowtimo; static TAILQ_HEAD(slirp_instances, Slirp) slirp_instances = TAILQ_HEAD_INITIALIZER(slirp_instances); -struct in_addr dns_addr = { 0 }; -u_int dns_addr_time = 0; +static struct in_addr dns_addr; +static u_int dns_addr_time; #ifdef _WIN32