From patchwork Fri Aug 28 18:27:26 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 32428 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id A0FADB7B5C for ; Sat, 29 Aug 2009 05:17:45 +1000 (EST) Received: from localhost ([127.0.0.1]:43161 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mh6xC-0007qj-9y for incoming@patchwork.ozlabs.org; Fri, 28 Aug 2009 15:17:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mh6Bx-0007u0-Vz for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:28:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mh6Bw-0007s7-6V for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:28:53 -0400 Received: from [199.232.76.173] (port=41314 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mh6Bw-0007rp-1D for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:28:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14381) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mh6Bv-0003B8-Ab for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:28:51 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7SISodK029373; Fri, 28 Aug 2009 14:28:50 -0400 Received: from localhost (vpn-10-114.bos.redhat.com [10.16.10.114]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7SISmQk007502; Fri, 28 Aug 2009 14:28:49 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Fri, 28 Aug 2009 15:27:26 -0300 Message-Id: <1251484052-3939-24-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1251484052-3939-1-git-send-email-lcapitulino@redhat.com> References: <1251484052-3939-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: aliguori@us.ibm.com, avi@redhat.com Subject: [Qemu-devel] [PATCH 23/29] monitor: fail when 'i' type is greater than 32-bit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The 'i' argument type is for 32-bit only and most handlers will use an 'int' to store its value. It's better to fail gracefully when the user enters a value greater than 32-bit than to get subtle casting bugs. Signed-off-by: Luiz Capitulino --- monitor.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 37b895c..5e0abd0 100644 --- a/monitor.c +++ b/monitor.c @@ -2759,6 +2759,12 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon, } if (get_expr(mon, &val, &p)) goto fail; + /* Check if 'i' is greater than 32-bit */ + if ((c == 'i') && ((val >> 32) & 0xffffffff)) { + monitor_printf(mon, "\'%s\' has failed: ", cmdname); + monitor_printf(mon, "integer is for 32-bit values\n"); + goto fail; + } qdict_put(qdict, key, qint_from_int(val)); } break;