mbox series

[v2,0/4] util/uri: Simplify the code, remove unused functions

Message ID 20240123182247.432642-1-thuth@redhat.com
Headers show
Series util/uri: Simplify the code, remove unused functions | expand

Message

Thomas Huth Jan. 23, 2024, 6:22 p.m. UTC 
The URI function uri_string_unescape() is pretty much the same as the
function g_uri_unescape_segment() from the glib, so we can simplify
our code here quite a bit.
While at it, I also noticed that there are many other unused functions
in here which we likely can drop, too.

v2:
- Replace uri_string_unescape() with g_uri_unescape_segment(), so
  we can remove uri_string_unescape() completely now

Thomas Huth (4):
  util/uri: Remove uri_string_unescape()
  util/uri: Remove unused functions uri_resolve() and
    uri_resolve_relative()
  util/uri: Remove the uri_string_escape() function
  util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()

 include/qemu/uri.h |   4 -
 util/uri.c         | 869 +--------------------------------------------
 2 files changed, 11 insertions(+), 862 deletions(-)

Comments

Richard Henderson Jan. 23, 2024, 9:23 p.m. UTC | #1 
On 1/24/24 04:22, Thomas Huth wrote:
> Thomas Huth (4):
>    util/uri: Remove uri_string_unescape()
>    util/uri: Remove unused functions uri_resolve() and
>      uri_resolve_relative()
>    util/uri: Remove the uri_string_escape() function
>    util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~