| Message ID | 20240110231537.1654478-1-ninad@linux.ibm.com |
|---|---|
| Headers | show |
| Series | Introduce model for IBM's FSI | expand |
Hello Ninad, This is looking much better. I have a couple more comments. Please wait a little before sending a respin ! :) and please run make check and script/checkpatch.pl. On 1/11/24 00:15, Ninad Palsule wrote: > Hello, > > Please review the patch-set version 10. > I have incorporated review comments from Cedric. > v10: > - Moved aspeed-apb2opb to hw/misc directory So, it looked better before ... can you please move it back to the fsi dir ? Sorry about that. Thanks, C. > - Moved scratchpad to lbus files. > - Moved fsi-slave to fsi files. > - Merged opb changes in the aspeed-apb2opb files > - Reduced number of config option to 2 > > Ninad Palsule (9): > hw/fsi: Introduce IBM's Local bus and scratchpad > hw/fsi: Introduce IBM's FSI Bus and FSI slave > hw/fsi: Introduce IBM's cfam > hw/fsi: Introduce IBM's FSI master > hw/fsi: Aspeed APB2OPB interface, Onchip perif bus > hw/arm: Hook up FSI module in AST2600 > hw/fsi: Added qtest > hw/fsi: Added FSI documentation > hw/fsi: Update MAINTAINER list > > MAINTAINERS | 8 + > docs/specs/fsi.rst | 138 +++++++++++++ > docs/specs/index.rst | 1 + > meson.build | 1 + > hw/fsi/trace.h | 1 + > include/hw/arm/aspeed_soc.h | 4 + > include/hw/fsi/cfam.h | 34 ++++ > include/hw/fsi/fsi-master.h | 32 +++ > include/hw/fsi/fsi.h | 38 ++++ > include/hw/fsi/lbus.h | 52 +++++ > include/hw/misc/aspeed-apb2opb.h | 50 +++++ > hw/arm/aspeed_ast2600.c | 19 ++ > hw/fsi/cfam.c | 182 +++++++++++++++++ > hw/fsi/fsi-master.c | 173 ++++++++++++++++ > hw/fsi/fsi.c | 111 ++++++++++ > hw/fsi/lbus.c | 121 +++++++++++ > hw/misc/aspeed-apb2opb.c | 338 +++++++++++++++++++++++++++++++ > tests/qtest/aspeed-fsi-test.c | 205 +++++++++++++++++++ > hw/Kconfig | 1 + > hw/arm/Kconfig | 1 + > hw/fsi/Kconfig | 2 + > hw/fsi/meson.build | 1 + > hw/fsi/trace-events | 11 + > hw/meson.build | 1 + > hw/misc/Kconfig | 5 + > hw/misc/meson.build | 1 + > hw/misc/trace-events | 4 + > tests/qtest/meson.build | 1 + > 28 files changed, 1536 insertions(+) > create mode 100644 docs/specs/fsi.rst > create mode 100644 hw/fsi/trace.h > create mode 100644 include/hw/fsi/cfam.h > create mode 100644 include/hw/fsi/fsi-master.h > create mode 100644 include/hw/fsi/fsi.h > create mode 100644 include/hw/fsi/lbus.h > create mode 100644 include/hw/misc/aspeed-apb2opb.h > create mode 100644 hw/fsi/cfam.c > create mode 100644 hw/fsi/fsi-master.c > create mode 100644 hw/fsi/fsi.c > create mode 100644 hw/fsi/lbus.c > create mode 100644 hw/misc/aspeed-apb2opb.c > create mode 100644 tests/qtest/aspeed-fsi-test.c > create mode 100644 hw/fsi/Kconfig > create mode 100644 hw/fsi/meson.build > create mode 100644 hw/fsi/trace-events >