| Message ID | 20231026164741.1184058-1-ninad@linux.ibm.com |
|---|---|
| Headers | show |
| Series | Introduce model for IBM's FSI | expand |
Hello Ninad, On 10/26/23 18:47, Ninad Palsule wrote: > Hello, > > Please review the patch-set version 7. > I have incorporated review comments from Cedric, Philippe and Thomas. I reworked v7 with the suggestions I made in patches 1-6. Please check : https://github.com/legoater/qemu/commits/aspeed-8.2 I will have more questions on the mappings because some parts are really unclear. Thanks, C. > > Ninad Palsule (10): > hw/fsi: Introduce IBM's Local bus > hw/fsi: Introduce IBM's scratchpad > hw/fsi: Introduce IBM's cfam,fsi-slave > hw/fsi: Introduce IBM's FSI > hw/fsi: IBM's On-chip Peripheral Bus > hw/fsi: Aspeed APB2OPB interface > hw/arm: Hook up FSI module in AST2600 > hw/fsi: Added qtest > hw/fsi: Added FSI documentation > hw/fsi: Update MAINTAINER list > > MAINTAINERS | 8 + > docs/specs/fsi.rst | 138 +++++++++++++++ > docs/specs/index.rst | 1 + > meson.build | 1 + > hw/fsi/trace.h | 1 + > include/hw/arm/aspeed_soc.h | 4 + > include/hw/fsi/aspeed-apb2opb.h | 33 ++++ > include/hw/fsi/cfam.h | 34 ++++ > include/hw/fsi/engine-scratchpad.h | 27 +++ > include/hw/fsi/fsi-master.h | 30 ++++ > include/hw/fsi/fsi-slave.h | 29 +++ > include/hw/fsi/fsi.h | 36 ++++ > include/hw/fsi/lbus.h | 43 +++++ > include/hw/fsi/opb.h | 33 ++++ > hw/arm/aspeed_ast2600.c | 19 ++ > hw/fsi/aspeed-apb2opb.c | 272 +++++++++++++++++++++++++++++ > hw/fsi/cfam.c | 173 ++++++++++++++++++ > hw/fsi/engine-scratchpad.c | 93 ++++++++++ > hw/fsi/fsi-master.c | 161 +++++++++++++++++ > hw/fsi/fsi-slave.c | 78 +++++++++ > hw/fsi/fsi.c | 25 +++ > hw/fsi/lbus.c | 74 ++++++++ > hw/fsi/opb.c | 74 ++++++++ > tests/qtest/aspeed-fsi-test.c | 205 ++++++++++++++++++++++ > hw/Kconfig | 1 + > hw/arm/Kconfig | 1 + > hw/fsi/Kconfig | 23 +++ > hw/fsi/meson.build | 6 + > hw/fsi/trace-events | 13 ++ > hw/meson.build | 1 + > tests/qtest/meson.build | 1 + > 31 files changed, 1638 insertions(+) > create mode 100644 docs/specs/fsi.rst > create mode 100644 hw/fsi/trace.h > create mode 100644 include/hw/fsi/aspeed-apb2opb.h > create mode 100644 include/hw/fsi/cfam.h > create mode 100644 include/hw/fsi/engine-scratchpad.h > create mode 100644 include/hw/fsi/fsi-master.h > create mode 100644 include/hw/fsi/fsi-slave.h > create mode 100644 include/hw/fsi/fsi.h > create mode 100644 include/hw/fsi/lbus.h > create mode 100644 include/hw/fsi/opb.h > create mode 100644 hw/fsi/aspeed-apb2opb.c > create mode 100644 hw/fsi/cfam.c > create mode 100644 hw/fsi/engine-scratchpad.c > create mode 100644 hw/fsi/fsi-master.c > create mode 100644 hw/fsi/fsi-slave.c > create mode 100644 hw/fsi/fsi.c > create mode 100644 hw/fsi/lbus.c > create mode 100644 hw/fsi/opb.c > create mode 100644 tests/qtest/aspeed-fsi-test.c > create mode 100644 hw/fsi/Kconfig > create mode 100644 hw/fsi/meson.build > create mode 100644 hw/fsi/trace-events >
Hello Cedric, On 11/27/23 10:31, Cédric Le Goater wrote: > Hello Ninad, > > On 10/26/23 18:47, Ninad Palsule wrote: >> Hello, >> >> Please review the patch-set version 7. >> I have incorporated review comments from Cedric, Philippe and Thomas. > > > I reworked v7 with the suggestions I made in patches 1-6. Please check : > > https://github.com/legoater/qemu/commits/aspeed-8.2 > > I will have more questions on the mappings because some parts are really > unclear. > Thanks for the changes. I have 2 changes. I will send it as v8. Regards, Ninad > > Thanks, > > C. > > >> >> Ninad Palsule (10): >> hw/fsi: Introduce IBM's Local bus >> hw/fsi: Introduce IBM's scratchpad >> hw/fsi: Introduce IBM's cfam,fsi-slave >> hw/fsi: Introduce IBM's FSI >> hw/fsi: IBM's On-chip Peripheral Bus >> hw/fsi: Aspeed APB2OPB interface >> hw/arm: Hook up FSI module in AST2600 >> hw/fsi: Added qtest >> hw/fsi: Added FSI documentation >> hw/fsi: Update MAINTAINER list >> >> MAINTAINERS | 8 + >> docs/specs/fsi.rst | 138 +++++++++++++++ >> docs/specs/index.rst | 1 + >> meson.build | 1 + >> hw/fsi/trace.h | 1 + >> include/hw/arm/aspeed_soc.h | 4 + >> include/hw/fsi/aspeed-apb2opb.h | 33 ++++ >> include/hw/fsi/cfam.h | 34 ++++ >> include/hw/fsi/engine-scratchpad.h | 27 +++ >> include/hw/fsi/fsi-master.h | 30 ++++ >> include/hw/fsi/fsi-slave.h | 29 +++ >> include/hw/fsi/fsi.h | 36 ++++ >> include/hw/fsi/lbus.h | 43 +++++ >> include/hw/fsi/opb.h | 33 ++++ >> hw/arm/aspeed_ast2600.c | 19 ++ >> hw/fsi/aspeed-apb2opb.c | 272 +++++++++++++++++++++++++++++ >> hw/fsi/cfam.c | 173 ++++++++++++++++++ >> hw/fsi/engine-scratchpad.c | 93 ++++++++++ >> hw/fsi/fsi-master.c | 161 +++++++++++++++++ >> hw/fsi/fsi-slave.c | 78 +++++++++ >> hw/fsi/fsi.c | 25 +++ >> hw/fsi/lbus.c | 74 ++++++++ >> hw/fsi/opb.c | 74 ++++++++ >> tests/qtest/aspeed-fsi-test.c | 205 ++++++++++++++++++++++ >> hw/Kconfig | 1 + >> hw/arm/Kconfig | 1 + >> hw/fsi/Kconfig | 23 +++ >> hw/fsi/meson.build | 6 + >> hw/fsi/trace-events | 13 ++ >> hw/meson.build | 1 + >> tests/qtest/meson.build | 1 + >> 31 files changed, 1638 insertions(+) >> create mode 100644 docs/specs/fsi.rst >> create mode 100644 hw/fsi/trace.h >> create mode 100644 include/hw/fsi/aspeed-apb2opb.h >> create mode 100644 include/hw/fsi/cfam.h >> create mode 100644 include/hw/fsi/engine-scratchpad.h >> create mode 100644 include/hw/fsi/fsi-master.h >> create mode 100644 include/hw/fsi/fsi-slave.h >> create mode 100644 include/hw/fsi/fsi.h >> create mode 100644 include/hw/fsi/lbus.h >> create mode 100644 include/hw/fsi/opb.h >> create mode 100644 hw/fsi/aspeed-apb2opb.c >> create mode 100644 hw/fsi/cfam.c >> create mode 100644 hw/fsi/engine-scratchpad.c >> create mode 100644 hw/fsi/fsi-master.c >> create mode 100644 hw/fsi/fsi-slave.c >> create mode 100644 hw/fsi/fsi.c >> create mode 100644 hw/fsi/lbus.c >> create mode 100644 hw/fsi/opb.c >> create mode 100644 tests/qtest/aspeed-fsi-test.c >> create mode 100644 hw/fsi/Kconfig >> create mode 100644 hw/fsi/meson.build >> create mode 100644 hw/fsi/trace-events >> >
Hello Cedric, On 11/27/23 10:31, Cédric Le Goater wrote: > Hello Ninad, > > On 10/26/23 18:47, Ninad Palsule wrote: >> Hello, >> >> Please review the patch-set version 7. >> I have incorporated review comments from Cedric, Philippe and Thomas. > > > I reworked v7 with the suggestions I made in patches 1-6. Please check : > > https://github.com/legoater/qemu/commits/aspeed-8.2 > > I will have more questions on the mappings because some parts are really > unclear. > I forgot to mention in my last mail. If I build against your aspeed-8.2 branch then rainier machine is failing to boot. The same images are working with qemu master branch. fsi/qemu-system-arm -M rainier-bmc -nographic -kernel ./fitImage-linux.bin -dtb ./aspeed-bmc-ibm-rainier.dtb -initrd ./obmc-phosphor-initramfs.rootfs.cpio.xz -drive file=./obmc-phosphor-image.rootfs.wic.qcow2,if=sd,index=2 -append 'rootwait console=ttyS4,115200n8 root=PARTLABEL=rofs-a' -net nic -net user,hostfwd=:127.0.0.1:3222-:22,hostfwd=:127.0.0.1:2234-:1234 -trace 'fsi*' | | Starting systemd-udevd version 254^ [ 50.630407] /dev/disk/by-partlabel/rofs-a: Can't open blockdev mount: mounting /dev/disk/by-partlabel/rofs-a on /mnt/rofs failed: No such file or directory /bin/sh: can't access tty; job control turned off > > Thanks, > > C. > > >> >> Ninad Palsule (10): >> hw/fsi: Introduce IBM's Local bus >> hw/fsi: Introduce IBM's scratchpad >> hw/fsi: Introduce IBM's cfam,fsi-slave >> hw/fsi: Introduce IBM's FSI >> hw/fsi: IBM's On-chip Peripheral Bus >> hw/fsi: Aspeed APB2OPB interface >> hw/arm: Hook up FSI module in AST2600 >> hw/fsi: Added qtest >> hw/fsi: Added FSI documentation >> hw/fsi: Update MAINTAINER list >> >> MAINTAINERS | 8 + >> docs/specs/fsi.rst | 138 +++++++++++++++ >> docs/specs/index.rst | 1 + >> meson.build | 1 + >> hw/fsi/trace.h | 1 + >> include/hw/arm/aspeed_soc.h | 4 + >> include/hw/fsi/aspeed-apb2opb.h | 33 ++++ >> include/hw/fsi/cfam.h | 34 ++++ >> include/hw/fsi/engine-scratchpad.h | 27 +++ >> include/hw/fsi/fsi-master.h | 30 ++++ >> include/hw/fsi/fsi-slave.h | 29 +++ >> include/hw/fsi/fsi.h | 36 ++++ >> include/hw/fsi/lbus.h | 43 +++++ >> include/hw/fsi/opb.h | 33 ++++ >> hw/arm/aspeed_ast2600.c | 19 ++ >> hw/fsi/aspeed-apb2opb.c | 272 +++++++++++++++++++++++++++++ >> hw/fsi/cfam.c | 173 ++++++++++++++++++ >> hw/fsi/engine-scratchpad.c | 93 ++++++++++ >> hw/fsi/fsi-master.c | 161 +++++++++++++++++ >> hw/fsi/fsi-slave.c | 78 +++++++++ >> hw/fsi/fsi.c | 25 +++ >> hw/fsi/lbus.c | 74 ++++++++ >> hw/fsi/opb.c | 74 ++++++++ >> tests/qtest/aspeed-fsi-test.c | 205 ++++++++++++++++++++++ >> hw/Kconfig | 1 + >> hw/arm/Kconfig | 1 + >> hw/fsi/Kconfig | 23 +++ >> hw/fsi/meson.build | 6 + >> hw/fsi/trace-events | 13 ++ >> hw/meson.build | 1 + >> tests/qtest/meson.build | 1 + >> 31 files changed, 1638 insertions(+) >> create mode 100644 docs/specs/fsi.rst >> create mode 100644 hw/fsi/trace.h >> create mode 100644 include/hw/fsi/aspeed-apb2opb.h >> create mode 100644 include/hw/fsi/cfam.h >> create mode 100644 include/hw/fsi/engine-scratchpad.h >> create mode 100644 include/hw/fsi/fsi-master.h >> create mode 100644 include/hw/fsi/fsi-slave.h >> create mode 100644 include/hw/fsi/fsi.h >> create mode 100644 include/hw/fsi/lbus.h >> create mode 100644 include/hw/fsi/opb.h >> create mode 100644 hw/fsi/aspeed-apb2opb.c >> create mode 100644 hw/fsi/cfam.c >> create mode 100644 hw/fsi/engine-scratchpad.c >> create mode 100644 hw/fsi/fsi-master.c >> create mode 100644 hw/fsi/fsi-slave.c >> create mode 100644 hw/fsi/fsi.c >> create mode 100644 hw/fsi/lbus.c >> create mode 100644 hw/fsi/opb.c >> create mode 100644 tests/qtest/aspeed-fsi-test.c >> create mode 100644 hw/fsi/Kconfig >> create mode 100644 hw/fsi/meson.build >> create mode 100644 hw/fsi/trace-events >> >
On 11/29/23 15:56, Ninad Palsule wrote: > Hello Cedric, > > On 11/27/23 10:31, Cédric Le Goater wrote: >> Hello Ninad, >> >> On 10/26/23 18:47, Ninad Palsule wrote: >>> Hello, >>> >>> Please review the patch-set version 7. >>> I have incorporated review comments from Cedric, Philippe and Thomas. >> >> >> I reworked v7 with the suggestions I made in patches 1-6. Please check : >> >> https://github.com/legoater/qemu/commits/aspeed-8.2 >> >> I will have more questions on the mappings because some parts are really >> unclear. >> > I forgot to mention in my last mail. If I build against your aspeed-8.2 branch then rainier machine is failing to boot. > > The same images are working with qemu master branch. > > fsi/qemu-system-arm -M rainier-bmc -nographic -kernel ./fitImage-linux.bin -dtb ./aspeed-bmc-ibm-rainier.dtb -initrd ./obmc-phosphor-initramfs.rootfs.cpio.xz -drive file=./obmc-phosphor-image.rootfs.wic.qcow2,if=sd,index=2 -append 'rootwait console=ttyS4,115200n8 root=PARTLABEL=rofs-a' -net nic -net user,hostfwd=:127.0.0.1:3222-:22,hostfwd=:127.0.0.1:2234-:1234 -trace 'fsi*' > | > | > Starting systemd-udevd version 254^ > [ 50.630407] /dev/disk/by-partlabel/rofs-a: Can't open blockdev > mount: mounting /dev/disk/by-partlabel/rofs-a on /mnt/rofs failed: No such file or directory > /bin/sh: can't access tty; job control turned off Hello, Please try with '-M rainier-bmc,boot-emmc=false' to avoid using the boot emmc mode which is the default for the rainier machine. I just updated the aspeed-8.2 branch to take into account the -kernel option when booting the rainier. Thanks, C.
On 11/29/23 22:29, Cédric Le Goater wrote: > On 11/29/23 15:56, Ninad Palsule wrote: >> Hello Cedric, >> >> On 11/27/23 10:31, Cédric Le Goater wrote: >>> Hello Ninad, >>> >>> On 10/26/23 18:47, Ninad Palsule wrote: >>>> Hello, >>>> >>>> Please review the patch-set version 7. >>>> I have incorporated review comments from Cedric, Philippe and Thomas. >>> >>> >>> I reworked v7 with the suggestions I made in patches 1-6. Please check : >>> >>> https://github.com/legoater/qemu/commits/aspeed-8.2 >>> >>> I will have more questions on the mappings because some parts are really >>> unclear. >>> >> I forgot to mention in my last mail. If I build against your aspeed-8.2 branch then rainier machine is failing to boot. >> >> The same images are working with qemu master branch. >> >> fsi/qemu-system-arm -M rainier-bmc -nographic -kernel ./fitImage-linux.bin -dtb ./aspeed-bmc-ibm-rainier.dtb -initrd ./obmc-phosphor-initramfs.rootfs.cpio.xz -drive file=./obmc-phosphor-image.rootfs.wic.qcow2,if=sd,index=2 -append 'rootwait console=ttyS4,115200n8 root=PARTLABEL=rofs-a' -net nic -net user,hostfwd=:127.0.0.1:3222-:22,hostfwd=:127.0.0.1:2234-:1234 -trace 'fsi*' >> | >> | >> Starting systemd-udevd version 254^ >> [ 50.630407] /dev/disk/by-partlabel/rofs-a: Can't open blockdev >> mount: mounting /dev/disk/by-partlabel/rofs-a on /mnt/rofs failed: No such file or directory >> /bin/sh: can't access tty; job control turned off > > Hello, > > Please try with '-M rainier-bmc,boot-emmc=false' to avoid using the > boot emmc mode which is the default for the rainier machine. > > I just updated the aspeed-8.2 branch to take into account the -kernel > option when booting the rainier. Instead, please update your emmc file image which should contain a boot area with u-boot.spl and uboot. See patch "hw/sd: Support boot area in emmc image". Or use '-M rainier-bmc,boot-emmc=false' Thanks, C.
Hello Cedric, On 11/29/23 15:29, Cédric Le Goater wrote: > On 11/29/23 15:56, Ninad Palsule wrote: >> Hello Cedric, >> >> On 11/27/23 10:31, Cédric Le Goater wrote: >>> Hello Ninad, >>> >>> On 10/26/23 18:47, Ninad Palsule wrote: >>>> Hello, >>>> >>>> Please review the patch-set version 7. >>>> I have incorporated review comments from Cedric, Philippe and Thomas. >>> >>> >>> I reworked v7 with the suggestions I made in patches 1-6. Please >>> check : >>> >>> https://github.com/legoater/qemu/commits/aspeed-8.2 >>> >>> I will have more questions on the mappings because some parts are >>> really >>> unclear. >>> >> I forgot to mention in my last mail. If I build against your >> aspeed-8.2 branch then rainier machine is failing to boot. >> >> The same images are working with qemu master branch. >> >> fsi/qemu-system-arm -M rainier-bmc -nographic -kernel >> ./fitImage-linux.bin -dtb ./aspeed-bmc-ibm-rainier.dtb -initrd >> ./obmc-phosphor-initramfs.rootfs.cpio.xz -drive >> file=./obmc-phosphor-image.rootfs.wic.qcow2,if=sd,index=2 -append >> 'rootwait console=ttyS4,115200n8 root=PARTLABEL=rofs-a' -net nic -net >> user,hostfwd=:127.0.0.1:3222-:22,hostfwd=:127.0.0.1:2234-:1234 -trace >> 'fsi*' >> | >> | >> Starting systemd-udevd version 254^ >> [ 50.630407] /dev/disk/by-partlabel/rofs-a: Can't open blockdev >> mount: mounting /dev/disk/by-partlabel/rofs-a on /mnt/rofs failed: No >> such file or directory >> /bin/sh: can't access tty; job control turned off > > Hello, > > Please try with '-M rainier-bmc,boot-emmc=false' to avoid using the > boot emmc mode which is the default for the rainier machine. > > I just updated the aspeed-8.2 branch to take into account the -kernel > option when booting the rainier. That worked. Thanks! > > > Thanks, > > C. > > >