mbox series

[v2,0/4] block/blkio: fix opening virtio-blk drivers

Message ID 20230727161020.84213-1-sgarzare@redhat.com
Headers show
Series block/blkio: fix opening virtio-blk drivers | expand

Message

Stefano Garzarella July 27, 2023, 4:10 p.m. UTC
There is a problem with virtio-blk-vhost-vdpa.
The first patch does some preparation changes. The second and third patches
fix the issues, the last patch tries to prepare QEMU for a future version of
libblkio where we can use blkio_set_fd() to check whether the property is
supported or not.

While testing, I realized that the main problem was that qemu_open() does not
support UDS, but still the problem with blkio_connect() which can fail remains.

v2:
- added first patch in preparation of the others
- reworked patch 2 retrying blkio_connect [Stefan]
- added patch 3 since qemu_open() fails in UDS
- changed patch 4 commit description [Stefan]

v1: https://lore.kernel.org/qemu-devel/20230724154611.178858-1-sgarzare@redhat.com/

Based on stefanha/block branch.

Stefano Garzarella (4):
  block/blkio: move blkio_connect() in the drivers functions
  block/blkio: retry blkio_connect() if it fails using `fd`
  block/blkio: fall back on using `path` when `fd` setting fails
  block/blkio: use blkio_set_int("fd") to check fd support

 block/blkio.c | 108 +++++++++++++++++++++++++++++++++++---------------
 1 file changed, 75 insertions(+), 33 deletions(-)

Comments

Stefan Hajnoczi July 27, 2023, 7:58 p.m. UTC | #1
On Thu, Jul 27, 2023 at 06:10:16PM +0200, Stefano Garzarella wrote:
> There is a problem with virtio-blk-vhost-vdpa.
> The first patch does some preparation changes. The second and third patches
> fix the issues, the last patch tries to prepare QEMU for a future version of
> libblkio where we can use blkio_set_fd() to check whether the property is
> supported or not.
> 
> While testing, I realized that the main problem was that qemu_open() does not
> support UDS, but still the problem with blkio_connect() which can fail remains.
> 
> v2:
> - added first patch in preparation of the others
> - reworked patch 2 retrying blkio_connect [Stefan]
> - added patch 3 since qemu_open() fails in UDS
> - changed patch 4 commit description [Stefan]
> 
> v1: https://lore.kernel.org/qemu-devel/20230724154611.178858-1-sgarzare@redhat.com/
> 
> Based on stefanha/block branch.
> 
> Stefano Garzarella (4):
>   block/blkio: move blkio_connect() in the drivers functions
>   block/blkio: retry blkio_connect() if it fails using `fd`
>   block/blkio: fall back on using `path` when `fd` setting fails
>   block/blkio: use blkio_set_int("fd") to check fd support
> 
>  block/blkio.c | 108 +++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 75 insertions(+), 33 deletions(-)
> 
> -- 
> 2.41.0
> 

Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block

Stefan